Double maximum header length #2353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes the permitted header length more permissive, 8,192 bytes, doubling the Phoenix default. Related to 4lejandrito/next-plausible#67
BundleMonUnchanged files (7)
No change in files bundle size Final result: ✅ View report in BundleMon website ➡️ |
aerosol
approved these changes
Oct 19, 2022
This was referenced Oct 19, 2022
vinibrsl
added a commit
that referenced
this pull request
Oct 26, 2022
This commit makes the permitted header length more permissive, 8,192 bytes, doubling the Phoenix default. Related to 4lejandrito/next-plausible#67
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This commit makes the permitted header length more permissive, 8,192 bytes, doubling the Phoenix default.
Related to 4lejandrito/next-plausible#67
Tests
I tried testing with ExUnit, but I could not reproduce the HTTP 431 Request Header Fields Too Large response. I guess this is because the HTTP server does not actually run in test environment. However, I tested this locally with curl and the HTTP 431 is fixed.
Changelog
Documentation
Dark mode