fix ownership transfer when is_selfhost=true #2455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BundleMonUnchanged files (7)
No change in files bundle size Final result: ✅ View report in BundleMon website ➡️ |
ruslandoga
commented
Nov 19, 2022
| if !Application.get_env(:plausible, :is_selfhost) do | ||
| if Application.get_env(:plausible, :is_selfhost) do | ||
| multi | ||
| else | ||
| end_trial_of_new_owner(multi, new_owner) | ||
| end |
There was a problem hiding this comment.
This was retuning nil in self-hosted which was causing errors like this
plausible_1 | Server: example.com:80 (http)
plausible_1 | Request: POST /sites/invitations/sRdJ6PQkueG7fx0sfcENk/accept
plausible_1 | ** (exit) an exception was raised:
plausible_1 | ** (FunctionClauseError) no function clause matching in Ecto.Multi.add_operation/3
plausible_1 | (ecto 3.8.4) lib/ecto/multi.ex:640: Ecto.Multi.add_operation(nil, :membership, {:changeset, #Ecto.Changeset<action: :update, changes: %{role: :owner}, errors: [], data: #Plausible.Site.Membership<>, valid?: true>, []})
plausible_1 | (plausible 0.0.1) lib/plausible_web/controllers/invitation_controller.ex:34: PlausibleWeb.InvitationController.accept_invitation/2
plausible_1 | (plausible 0.0.1) lib/plausible_web/controllers/invitation_controller.ex:1: PlausibleWeb.InvitationController.action/2
plausible_1 | (plausible 0.0.1) lib/plausible_web/controllers/invitation_controller.ex:1: PlausibleWeb.InvitationController.phoenix_controller_pipeline/2
plausible_1 | (phoenix 1.6.6) lib/phoenix/router.ex:355: Phoenix.Router.__call__/2
plausible_1 | (plausible 0.0.1) lib/plausible_web/endpoint.ex:1: PlausibleWeb.Endpoint.plug_builder_call/2
plausible_1 | (plausible 0.0.1) lib/plausible_web/endpoint.ex:1: PlausibleWeb.Endpoint."call (overridable 3)"/2
plausible_1 | (plausible 0.0.1) lib/plausible_web/endpoint.ex:1: PlausibleWeb.Endpoint.call/2
ukutaht
approved these changes
Nov 20, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes invitation links for ownership transfer in self-hosted setups.
More info: #2051
Tests
Changelog
Documentation
Dark mode