Always show direct traffic in sources reports #2531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes query param show_noref which was used from React to control whether to show Direct / None traffic or not. The show_noref behaviour was untested previously. Closes #2523
BundleMonFiles updated (1)
Unchanged files (6)
Total files change -41B 0% Final result: ✅ View report in BundleMon website ➡️ |
ukutaht
commented
Dec 19, 2022
|
|
||
| const detailed = this.showExtra() | ||
| api.get(`/api/stats/${encodeURIComponent(site.domain)}/${this.currentFilter()}`, query, {limit: 100, page, detailed, show_noref: true}) | ||
| .then((res) => this.setState({loading: false, sources: sources.concat(res), moreResultsAvailable: res.length === 100})) | ||
| api.get(`/api/stats/${encodeURIComponent(site.domain)}/${this.currentFilter()}`, query, { limit: 100, page, detailed }) |
There was a problem hiding this comment.
Sorry, the editor auto-formatted this file. Here's the real change.
| showConversionRate() { | ||
| return !!this.props.query.filters.goal | ||
| } | ||
|
|
||
| fetchReferrers() { | ||
| if (this.props.query.filters.source) { | ||
| api.get(`/api/stats/${encodeURIComponent(this.props.site.domain)}/referrers/${encodeURIComponent(this.props.query.filters.source)}`, this.props.query, {show_noref: this.showNoRef()}) | ||
| api.get(`/api/stats/${encodeURIComponent(this.props.site.domain)}/referrers/${encodeURIComponent(this.props.query.filters.source)}`, this.props.query) |
vinibrsl
approved these changes
Dec 19, 2022
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes query param show_noref which was used from React to control whether to show Direct / None traffic or not. The show_noref behaviour was untested previously.
The main visual change is that we used to not show
Direct / Nonein sources list by default. It would only be shown when you clicked on 'details'. Now it's always shown:Closes #2523
Changes
Tests
Changelog
Documentation
Dark mode