Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use user-agent instead of screen_width to get device type #2711

Merged
merged 11 commits into from
Mar 2, 2023

Conversation

ukutaht
Copy link
Contributor

@ukutaht ukutaht commented Feb 28, 2023

Changes

Follow-up for #1659:

  • More exhaustive matching for device types from matomo/device-detector
  • Reverted a change to the UI labels for now. Not sure if that's desirable.

Tests

  • Automated tests have been added

Changelog

  • Entry has been added to changelog

Documentation

  • Docs have been updated

Dark mode

  • This PR does not change the UI

@ukutaht ukutaht changed the title Ua device type rebase Use user-agent instead of screen_width to get device type Feb 28, 2023
@bundlemon
Copy link

bundlemon bot commented Feb 28, 2023

BundleMon

Files updated (2)
Status Path Size Limits
tracker/js/plausible.js
733B (-15B -2.01%) -
static/js/dashboard.js
297.96KB (-88B -0.03%) -
Unchanged files (5)
Status Path Size Limits
static/css/app.css
492.34KB -
static/js/app.js
12.13KB -
static/js/embed.host.js
5.58KB -
static/js/embed.content.js
5.06KB -
static/js/applyTheme.js
314B -

Total files change -103B -0.01%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@ukutaht ukutaht requested a review from a team February 28, 2023 12:34
@ukutaht
Copy link
Contributor Author

ukutaht commented Feb 28, 2023

This is just a rebased version of #2680 which was already approved by @vinibrsl.

@RobertJoonas this PR also removes the browserstack config and runs the Playwright tests directly on the CI runners. I couldn't get Browserstack to work anymore :/

@aerosol aerosol merged commit 43bf7dd into master Mar 2, 2023
@aerosol aerosol deleted the ua-device-type-rebase branch March 2, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants