Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedded dashboard fixes #2744

Merged
merged 3 commits into from
Mar 14, 2023
Merged

Embedded dashboard fixes #2744

merged 3 commits into from
Mar 14, 2023

Conversation

ukutaht
Copy link
Contributor

@ukutaht ukutaht commented Mar 13, 2023

Changes

Adds a default 1.5rem padding to embedded dashboards. This allows enough space for the shadows to render properly.

Fixes #1954

As a small improvement, also configures iframe-resizer with checkOrigin: false. This seems to have no effect on the actual behaviour but gets rid of an error log in console:

Screenshot 2023-03-13 at 16 54 32

Tests

  • This PR does not require tests

Changelog

  • Entry has been added to changelog

Documentation

  • This change does not need a documentation update

Dark mode

  • This PR does not change the UI

@bundlemon
Copy link

bundlemon bot commented Mar 13, 2023

BundleMon

Unchanged files (7)
Status Path Size Limits
static/css/app.css
492.34KB -
static/js/dashboard.js
298.26KB -
static/js/app.js
12.13KB -
static/js/embed.host.js
5.58KB -
static/js/embed.content.js
5.06KB -
tracker/js/plausible.js
733B -
static/js/applyTheme.js
314B -

Total files change +5B 0%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@ukutaht ukutaht changed the title Add padding to embedded dashboards Embedded dashboard fixes Mar 13, 2023
@vinibrsl vinibrsl merged commit 8c8cf23 into master Mar 14, 2023
@vinibrsl vinibrsl deleted the add-padding-to-embed branch March 14, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shadow are cut outside the iframe on the embed
2 participants