-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow domain change #2803
Allow domain change #2803
Conversation
BundleMonUnchanged files (7)
No change in files bundle size Final result: ✅ View report in BundleMon website ➡️ |
dc84f79
to
5eaaa25
Compare
5eaaa25
to
c0f51c5
Compare
Co-authored-by: Vini Brasil <vini@hey.com>
Co-authored-by: Vini Brasil <vini@hey.com>
I've added a note to CHANGELOG via e6a56b4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good to me.
Could a API endpoint be added to change a domain? |
@rphlo sure, we could add that. Do you mind describing your use case? |
I use the self hosted version, |
I believe it should be possible for the owner to switch back to its previous domain within the 72 hours period. Site goes domain1.site > domain2.site > domain3.site > domain1.site, Would work |
@rphlo Thanks for sharing your use case. I've added the API endpoint. Please note however that this feature requires a complex database migration to work, it is still in experimental phase and we don't have this documented for self-hosters yet. And you are correct, in this implementation it's impossible to undo domain change without setting a temporary domain first, unless the 72h transition period ends. |
With 67317b2 repeated changes within the same site are allowed, no need for a temporary rename anymore. |
Changes
Ref #1080
This PR implements the ability to change a site's domain keeping the collected stats intact.
We grant users with 72 hours transition period in which they're expected to update their API credentials and tracker scripts to point at the new domain. During that time, both old and new domains are accepted within incoming traffic and are made unavailable for registration.
This change will be only live after V2 migration is done (Ref #2762 #2780) hence the "feature flag" required for it is
V2_MIGRATION_DONE=1
variable set.change-domain-light.mp4
change-domain-dark.mp4
Tests
Changelog
Updated
Documentation
plausible/docs#380
Dark mode