-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix qemu arm64 builds #2879
fix qemu arm64 builds #2879
Conversation
BundleMonUnchanged files (7)
No change in files bundle size Final result: ✅ View report in BundleMon website ➡️ |
I've tagged this commit UPDATE: seems fixed. I'll try running that image on aws t4g (arm64 instance) UPDATE: the container doesn't start on aws t4g
Seems like FROM alpine:3.17.0@sha256:c0d488a800e4127c334ad20d61d7bc21b4097540327217dfab52262adc02380c pins to Ping @cnkk $ docker inspect alpine:3.17.0@sha256:c0d488a800e4127c334ad20d61d7bc21b4097540327217dfab52262adc02380c --format "{{ .Architecture }}"
amd64 Is it possible to pin to multi-arch image? Seems not. But maybe we can provide sha in build args like FROM alpine:3.17.0@sha256:$ALPINE_SHA_${TARGETARCH} this doesn't work but maybe some similar approach would. UPDATE: unpinning to FROM alpine:3.17.0 lets it build on aws t4g. $ docker run -ti --rm local-build ash
~ $ uname -a
Linux 483704a3d705 6.1.23-36.46.amzn2023.aarch64 #1 SMP Mon Apr 10 22:42:58 UTC 2023 aarch64 Linux It starts I'll try unpinning it in this PR and run the resulting image on aws t4g again. UPDATE: the image works both on t4g and t2 instances, https://who.copycat.fun is now running |
Correct, this won't work. Images built from the same Dockerfile and base image but with different architectures will have a different sha256 hashsum.
The problem with moving the sha256 hash to a variable is, that we'll loose the dependabot auto updates for the image. |
Changes
This PR adds
ERL_FLAGS=+JPperf true
to public image builds to stop it from segfaulting in qemu when building for arm64. More info for why it works: erlang/otp#6340 (once v26 is released, we can switch to+JMsingle bool
)Tests
Changelog
Documentation
Dark mode