Allow optional IPv6 for clickhouse repo #2970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This ought to replace the ungodly |
ruslandoga
reviewed
May 25, 2023
ruslandoga
reviewed
May 25, 2023
ruslandoga
reviewed
May 25, 2023
|
I've never actually written in this language before, so which options do you want me to use? |
|
I think get_var_from_path_or_env(config_dir, "ECTO_CH_IPV6", "false")
|> String.to_existing_atom()that Uku suggested would be the most consistent. Let's go with that. |
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
|
Got it, thanks for the pointers! |
BundleMonUnchanged files (7)
No change in files bundle size Final result: ✅ View report in BundleMon website ➡️ |
ruslandoga
approved these changes
May 26, 2023
|
Ah I see this missed 2.0, shame. Was anything else needed? |
Closed
1 task
aerosol
approved these changes
Jul 11, 2023
ruslandoga
added a commit
that referenced
this pull request
Jul 12, 2023
ruslandoga
pushed a commit
that referenced
this pull request
Jul 12, 2023
* Allow optional IPv6 for clickhouse repo Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space> * remove trailing comma --------- Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space> Co-authored-by: ruslandoga <rusl@n-do.ga>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds optional support for connect to clickhouse over ipv6. Same as #1661, but for clickhouse.
Tests
Changelog
Documentation
Dark mode