Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable registration by default in self-hosted setups #3014

Merged
merged 3 commits into from
Jun 14, 2023

Conversation

ruslandoga
Copy link
Contributor

@ruslandoga ruslandoga commented Jun 8, 2023

Changes

This PR disables registration in self-hosted setups. Note that the first user is allowed to register anyway (#2357).

Tests

  • This PR does not require tests

Changelog

  • Entry has been added to changelog

Documentation

Dark mode

  • Dark mode has been tested

@bundlemon
Copy link

bundlemon bot commented Jun 8, 2023

BundleMon

Unchanged files (7)
Status Path Size Limits
static/css/app.css
492.34KB -
static/js/dashboard.js
304.55KB -
static/js/app.js
12.31KB -
static/js/embed.host.js
5.58KB -
static/js/embed.content.js
5.06KB -
tracker/js/plausible.js
742B -
static/js/applyTheme.js
314B -

No change in files bundle size

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@ruslandoga ruslandoga mentioned this pull request Jun 8, 2023
4 tasks
@ruslandoga ruslandoga requested a review from ukutaht June 8, 2023 06:21
conn
|> put_flash(:error, "Registration is disabled on this instance")
|> redirect(to: Routes.auth_path(conn, :login_form))
|> halt()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2023-06-08 at 14 25 46 Screenshot 2023-06-08 at 14 26 15

@ukutaht ukutaht merged commit fd15853 into master Jun 14, 2023
@ukutaht ukutaht deleted the disable-registration-by-default branch June 14, 2023 09:08
ruslandoga pushed a commit that referenced this pull request Jun 27, 2023
* disable registration by default in self-hosted setups

* add changelog entry

* add error flash
ruslandoga pushed a commit that referenced this pull request Jun 27, 2023
* disable registration by default in self-hosted setups

* add changelog entry

* add error flash
ruslandoga pushed a commit to ruslandoga/plausible that referenced this pull request Jul 10, 2023
* disable registration by default in self-hosted setups

* add changelog entry

* add error flash
ruslandoga pushed a commit that referenced this pull request Jul 12, 2023
* disable registration by default in self-hosted setups

* add changelog entry

* add error flash
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants