Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape special regex characters #3634

Merged
merged 3 commits into from
Jan 17, 2024
Merged

Escape special regex characters #3634

merged 3 commits into from
Jan 17, 2024

Conversation

ukutaht
Copy link
Contributor

@ukutaht ukutaht commented Dec 14, 2023

Changes

Filters are currently broken when using special characters like . and ( in your filters. This PR fixes that.

It also makes a subtle change to how wildcards are interpreted and applied. * and ** used to be interpreted differently, but now they are completely equivalent. It's a breaking change but only for people who relied on the single * behaviour. We believe it's very rare and therefore not a big problem to make the change.

Tests

  • Automated tests have been added

Changelog

  • Entry has been added to changelog

Documentation

  • Docs have been updated

Dark mode

  • This PR does not change the UI

@ukutaht ukutaht requested a review from a team December 14, 2023 09:38
@ukutaht ukutaht merged commit a5e0619 into master Jan 17, 2024
5 checks passed
@ukutaht ukutaht deleted the regex-filter-escaping branch January 17, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants