Adds dark mode to entire dashboard #467
Conversation
This was a pain to test D:
(they looked bad, on second thought)
The PR number could be wrong, will double check
As I said, my Elixir is pretty weak heh
|
I like the dark gray styles more, but your blueish style looks cool too. Good job! |
|
Looks great |
|
Thanks! To be fair, most of my color choices revolve around the mockup that NuroDev made. |
|
@Vigasaurus ready for review? |
|
@ukutaht Yep 👍 |
There was a problem hiding this comment.
Looks good, I'm eager to merge. I have a few comments that I'd like to hash out, let's discuss further in replies to those individual comments.
EDIT: sorry about the merge conflicts. I am not working on any UI code, probably for the rest of the week. So I can promise no more conflicts if you do fix them at this point.
lib/plausible_web/templates/auth/password_reset_request_form.html.eex
Outdated
Show resolved
Hide resolved
|
👍 all comments make sense, I'll get em resolved tomorrow (in like 8-10 hours probably) - and I've got the new stuff on master almost done anyways. |
Of course, no pressure. If you don't finish it by tomorrow that's no problem. We are incredibly thankful for your contributions! |
|
This should be all good to go - I'll likely do another once-over to see if I missed anything with the added stuff/conflic resolution, but it should be ready :D |
Updates look good. I will merge once formatting issues are solved |
|
Yeah, I was using tabs, I would've assumed that VS Code would've picked the same indent style as the rest of the repo 🤷♂️ whoops. |
|
Thank you so much @Vigasaurus! This is a big job done well. I will deploy this later today 🚀🚀🚀🚀 |
|
nice!! looking forward to announcing this to the community and putting @Vigasaurus in our hall of fame list of contributors! |
* Adds New Dark Mode Assets * Moves triangle for dropdown to a reasonable position * Majority .eex dark implementation * Fixes Logo Positioning * Adds theme flag to user schema, uses it * Uses correct variables for theme applicator script * Minor missed theme changes/fallbacks * Individual Component Support + Theme Context * Sources Tab Support This was a pain to test D: * Partial Stats Sections Support * More of stats modules supported * Modal +table support * Improves some Flatpickr in light theme, supports dark theme * Fixes missed settings tab colors * Finishes Devices module support * Fixes bar graph colors * Better colorizes maps module * Undoes colorized bars (they looked bad, on second thought) * Fixes loading indicator * Finishes conversions module * Adds changelog entry The PR number could be wrong, will double check * Fixes missed header color * Fixes naming of migration and removes static alter * Does migration correctly As I said, my Elixir is pretty weak heh * Adds support for spike notifications setting * Improves contrast and visibility for email settings * Resolves @ukutaht's comments on plausible#467 * Fixes missing dark style * Found one more missed dark element (shared links) * Formatting fixes
Changes
Adds dark mode user option and system setting adherence across the entirety of the dashboard and otherwise authenticated user flows.
I do have this currently running at https://dev.vigneshjoglekar.com/plausible.io - but this is my personal VPS for all staging+my VS Code server so it could easily be down at random times. The benefit here is that I've got the real plausible demo data being pulled in, to make testing easier. (Feel free to let me know if its ever down and I can get it spun back up).
The above does also have a user setup if you wanted to check out other pages - user:
test@test.com, pw:passwdDefinitely do let me know if there are any issues or missing elements etc - I'd be happy to get them resolved!
Fixes #115
Tests
My Elixir is weak at best, I'm mostly unsure how/where exactly I'd add tests for my changes. I imagine it'd only be for the extra column in the user table, and its modification - but I'm unsure. I did also have to add a migration.
Changelog
Documentation
Again, I'm unsure if this needs any documentation change - besides maybe the contributors section 😉
Screenshots