-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use db-ip lite database for countries #906
Conversation
This is awesome! I was wondering about following things:
|
I think that would be best. I was planning to update it manually every time we tag a new release but I think automatically downloading it each time Docker build runs is better. Of course the ideal solution would be to download it in the background every month as it's updated. Even if we release new versions periodically it's not guaranteed that people will upgrade their plausible versions. I'm OK with having a manual update (like we do for User-Agent database and Referrer database) for now.
I've emailed the Creative Commons organization asking for clarification about this. Let's see what they say. |
License question is cleared up. Here's the response from db-ip people themselves:
@bhavin192 happy to accept your contribution to download the DB whenever the Docker image is built. If you don't have time I can probably do it myself as well. Let me know. |
That's great! I will take care of the container image changes. |
@bhavin192 I just added a task to download the latest DB from db-ip. I also rebased the history, the main point of this was to remove the actual file from the git history so it doesn't weight the repo down in the future. I'll merge this now and await for container updates from you. Thanks! |
@bhavin192 sorry I'm in a bit of a rush to get this version out so I added a download step to Dockerfile myself: 4fd5cdf |
@ukutaht ah, no worries, I got stuck with something else, that's why I was not able to do it yesterday. |
* Use DBIP database for countries * Add fake data for geolocation tests
Since v1.3.0 (or, more specifically, plausible/analytics#906) Plausible ships its own country database. Update the docs, leaving previous instructions example of getting another source of country data.
Changes
See discussion in #219. With this PR, a basic lite IP-to-Country database is included automatically with no need for extra configuration. Unlike Maxmind there seem to be no restrictions around packaging the database as part of our self-hosted offering as long as credit is given. This will greatly simplify development setups and self-hosted configuration.
Plausible Cloud will keep using MaxMind's database temporarily so we don't have to put up a license notice. But I think it would be a good idea to move to db-ip using their commercial (more accurate) database.
Db-ip also has a free and paid city databases which is great for the future.
Tests
Changelog
Documentation