-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update clickhouse to 22.6 #45
Conversation
@ukutaht would you be so kind as to review this change please? |
Thanks! I'll cut a new self-hosted release this/next week. I'll upgrade the dependencies then. |
@ukutaht, do you think anything will break when it is merged? I believe that MR is harmless and won't change anything for the worse but will improve the quality of life for ARM users. |
@ukutaht gentle ping. |
@ukutaht, another gentle ping for reviewing and merging this backwards-compatible change which doesn't break anything for anyone. I've removed the workaround for ARM problems from this PR as it's fixed in Clickhouse master and eventually will end up in the newer Clickhouse image. |
A little clarification: everything works completely fine for me, I've figured out a way to make it work under ARM, and I'm happy with it. The only thing which bugs me is that following the guide before this PR is merged gives you a setup which doesn't work under ARM, and the user has to go into GitHub issues and read a bunch before figuring out what has to be done. |
Can confirm it works. |
When new update, because all problem |
@ukutaht another gentle ping for reviewing and merging this PR. |
@ukutaht another ping here - ARM support would be amazing and this PR appears to work fine. |
Hello @ukutaht, I wonder if there is any chance of this and plausible/docs#240 PRs being merged? |
Pinging @ruslandoga with this one. He'll be cutting the next release so we'll update the CH version then as well. |
Also, previously we used Ubuntu base image. Now, we're switching to Alpine.
@ruslandoga, please review once more; it should be good to go now. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely a 👍🏻 from me!
I can't merge it, unfortunately. I hope you'll hit the button as well. UPD: nvm, I've understood you don't have the merge rights yet. |
@paskal thank you! |
@paskal Awesome, thanks for the PR. I wanted to set this up on my Pi. You mentioned it works for you. Can you by chance send me a config of yours? Currently the plausible/analytics:latest is still not ARM based and there are no ARM images here yet https://hub.docker.com/r/plausible/analytics/tags?page=1 |
v1.5.0 will not have ARM yet but it's something we're looking at for the next release |
@ukutaht Alright thanks! I used another image form another PR here regarding ARM and I can confirm that it is working on a Raspberry Pi 4 just changed the pausible image for that to an ARM based one. Thank you for this awesome tool 👍 |
@DennisLoska, just build it on the same Pi yourself. Here is the command: I personally use the tag |
@paskal Thank you so much! |
That version supports ARM and switches to alpine, which is 50MB smaller than Ubuntu (300MB) image.