Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update clickhouse to 22.6 #45

Merged
merged 1 commit into from
Sep 13, 2022
Merged

Update clickhouse to 22.6 #45

merged 1 commit into from
Sep 13, 2022

Conversation

paskal
Copy link
Sponsor Contributor

@paskal paskal commented Apr 23, 2022

That version supports ARM and switches to alpine, which is 50MB smaller than Ubuntu (300MB) image.

@paskal
Copy link
Sponsor Contributor Author

paskal commented Apr 30, 2022

@ukutaht would you be so kind as to review this change please?

@ukutaht
Copy link
Contributor

ukutaht commented May 2, 2022

Thanks! I'll cut a new self-hosted release this/next week. I'll upgrade the dependencies then.

@paskal
Copy link
Sponsor Contributor Author

paskal commented May 12, 2022

@ukutaht, do you think anything will break when it is merged? I believe that MR is harmless and won't change anything for the worse but will improve the quality of life for ARM users.

@paskal
Copy link
Sponsor Contributor Author

paskal commented Jun 6, 2022

@ukutaht gentle ping.

@paskal
Copy link
Sponsor Contributor Author

paskal commented Jun 15, 2022

@ukutaht, another gentle ping for reviewing and merging this backwards-compatible change which doesn't break anything for anyone. I've removed the workaround for ARM problems from this PR as it's fixed in Clickhouse master and eventually will end up in the newer Clickhouse image.

@paskal
Copy link
Sponsor Contributor Author

paskal commented Jun 15, 2022

A little clarification: everything works completely fine for me, I've figured out a way to make it work under ARM, and I'm happy with it. The only thing which bugs me is that following the guide before this PR is merged gives you a setup which doesn't work under ARM, and the user has to go into GitHub issues and read a bunch before figuring out what has to be done.

@BenRoe
Copy link

BenRoe commented Jun 21, 2022

Can confirm it works.

docker-compose.yml Outdated Show resolved Hide resolved
@productdevbook
Copy link

When new update, because all problem plausible/analytics:latest It would be great if you could fully update this repo now. Because it doesn't work @ukutaht

@paskal
Copy link
Sponsor Contributor Author

paskal commented Jul 22, 2022

@ukutaht another gentle ping for reviewing and merging this PR.

@micahlt
Copy link

micahlt commented Aug 2, 2022

@ukutaht another ping here - ARM support would be amazing and this PR appears to work fine.

@paskal
Copy link
Sponsor Contributor Author

paskal commented Aug 26, 2022

Hello @ukutaht, I wonder if there is any chance of this and plausible/docs#240 PRs being merged?

@ukutaht
Copy link
Contributor

ukutaht commented Sep 1, 2022

Pinging @ruslandoga with this one. He'll be cutting the next release so we'll update the CH version then as well.

@ruslandoga ruslandoga mentioned this pull request Sep 12, 2022
6 tasks
Also, previously we used Ubuntu base image.
Now, we're switching to Alpine.
@paskal
Copy link
Sponsor Contributor Author

paskal commented Sep 12, 2022

@ruslandoga, please review once more; it should be good to go now. Thank you!

Copy link
Contributor

@ruslandoga ruslandoga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely a 👍🏻 from me!

@paskal
Copy link
Sponsor Contributor Author

paskal commented Sep 12, 2022

I can't merge it, unfortunately. I hope you'll hit the button as well. UPD: nvm, I've understood you don't have the merge rights yet.

@ruslandoga ruslandoga merged commit 3177d22 into plausible:master Sep 13, 2022
@ruslandoga
Copy link
Contributor

@paskal thank you!

@paskal paskal deleted the paskal/newer_clickhouse branch September 13, 2022 07:55
@paskal paskal changed the title Update clickhouse to 22.4.2.1 Update clickhouse to 22.6 Sep 13, 2022
@DennisLoska
Copy link

@paskal Awesome, thanks for the PR. I wanted to set this up on my Pi. You mentioned it works for you. Can you by chance send me a config of yours? Currently the plausible/analytics:latest is still not ARM based and there are no ARM images here yet https://hub.docker.com/r/plausible/analytics/tags?page=1

@ukutaht
Copy link
Contributor

ukutaht commented Sep 14, 2022

v1.5.0 will not have ARM yet but it's something we're looking at for the next release

@DennisLoska
Copy link

DennisLoska commented Sep 14, 2022

@ukutaht Alright thanks! I used another image form another PR here regarding ARM and I can confirm that it is working on a Raspberry Pi 4 just changed the pausible image for that to an ARM based one. Thank you for this awesome tool 👍

@paskal
Copy link
Sponsor Contributor Author

paskal commented Sep 14, 2022

@DennisLoska, just build it on the same Pi yourself. Here is the command: git clone https://github.com/plausible/analytics.git && cd analytics && docker build --pull -t plausible/analytics:latest .

I personally use the tag plausible/analytics:arm-manual-build to make sure I won't accidentally break Plausible by pulling the wrong architecture from the DockerHub.

@DennisLoska
Copy link

@paskal Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants