Merge pull request #27 from ouuan/event-props-number-boolean

fix(request): accept number and boolean as event props
plausible · Apr 4, 2022 · 0369c0e · 0369c0e
2 parents 66e4e6c + d6461f9
commit 0369c0e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/lib/request.ts b/src/lib/request.ts
@@ -22,7 +22,7 @@ export type EventOptions = {
   /**
    * Properties to be bound to the event.
    */
-  readonly props?: { readonly [propName: string]: string };
+  readonly props?: { readonly [propName: string]: string | number | boolean };
 };
 
 /**

diff --git a/src/lib/tracker.spec.ts b/src/lib/tracker.spec.ts
@@ -35,6 +35,8 @@ describe('tracker', () => {
     props: {
       variation1: 'A',
       variation2: 'B',
+      variation3: 1,
+      variation4: true,
     },
   });
-Original file line number
+Diff line change
@@ Expand Up / @@ -22,7 +22,7 @@ export type EventOptions = { @@
       /**
        * Properties to be bound to the event.
        */
-      readonly props?: { readonly [propName: string]: string };
+      readonly props?: { readonly [propName: string]: string | number | boolean };
     };
     /**
@@ Expand Down @@