Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lvl compat #109

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Lvl compat #109

wants to merge 4 commits into from

Conversation

AngeloYazar
Copy link

Suggested changes in this pull request:

  1. Make the WebGL context configurable from the manifest
  2. Remove the skewx(0.00001deg) because it was causing stuttering on desktop
  3. Emit progress events from loader.js (Mainly for facebook)

@AngeloYazar AngeloYazar mentioned this pull request Sep 28, 2016
Open
@AngeloYazar
Copy link
Author

Added changes in 9601aae at Raymond's request, making premultipliedAlpha: true non-configurable.

rampr
rampr reviewed Sep 29, 2016
View reviewed changes
src/ui/resource/loader.js
// Emit progress event
this.emit('progress', {
progress: this.progress
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this work for native ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it just emits events on loader which inherits from Emitter. Just to be sure, I tested a build on android and the events came through.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rampr rampr rampr left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AngeloYazar @rampr