Add iPhone 14 Pro/Pro Max to SnapshotDevice definitions #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ra1028
approved these changes
Feb 16, 2023
|
@ra1028 Thank you for quick review and release! |
|
@akkyie |
|
@ra1028 Appreciate it! I see, will consider switching to use of SPM. Thanks for letting me know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Since iPhone 14 Pro and Pro Max have different geometry than previously defined devices such as iPhone 12 Pro/Pro Max, I added new definitions of them to SnapshotDevice.
Resolutions and safe area insets are measured manually. Resolutions are also confirmed with https://iosref.com/res.
Related Issue
Motivation and Context
Screenshots
One example taken from SnapshotTests