Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for iOS 16 - force safeAreaInsets update #53

Merged
merged 1 commit into from
Aug 16, 2023
Merged

fix for iOS 16 - force safeAreaInsets update #53

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions Sources/Playbook/SnapshotSupport/Internal/SnapshotWindow.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,14 @@ internal final class SnapshotWindow: UIWindow {
isHidden = false

if window != nil {
// In iOS 16 and 17, setting `isHidden` nor does not update
// the safeAreaInsets on the rootViewController's view. Updating
// `additionalSafeAreaInsets` will so force an update
if scenarioViewController.view.safeAreaInsets == .zero {
scenarioViewController.additionalSafeAreaInsets = .init(top: 1, left: 0, bottom: 0, right: 0)
scenarioViewController.additionalSafeAreaInsets = .zero
}

// Prioritise use snapshot device's `safeAreaInsets`
// by `additionalSafeAreaInsets` if having a parent window.
let originalSafeAreaInsets = scenarioViewController.view.safeAreaInsets
Expand Down