Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove scenario title's line limit #71

Merged
merged 2 commits into from
Jun 6, 2024
Merged

Remove scenario title's line limit #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
78b3e82
Remove scenario title's line limit
ra1028 Jun 6, 2024
faf1644
Use minimumScaleFactor
ra1028 Jun 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Sources/PlaybookUI/Internal/Views/GalleryThumbnail.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,8 @@ private struct NameLabel: View {
content: data.scenario.title.rawValue,
range: data.highlightRange
)
.textStyle(font: .caption, lineLimit: 3)
.textStyle(font: .caption)
.minimumScaleFactor(0.1)
.padding(.top, 4)
.padding([.bottom, .horizontal], 8)
.frame(maxWidth: .infinity)
Expand Down
9 changes: 9 additions & 0 deletions Tests/GalleryScenarios.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,15 @@ enum GalleryScenarios: ScenarioProvider {
Scenario("Detail", layout: .fill) { context in
GalleryDetail(data: .stub())
}

Scenario("Thumbnail with long title", layout: .compressed) { context in
GalleryThumbnail(
data: .stub(
"Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum."
)
)
.environmentObject(ImageLoader())
}
}
}
}
6 changes: 3 additions & 3 deletions Tests/Mocks.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,18 +26,18 @@ extension SelectData {
}

extension SearchedData {
static func stub(_ index: Int) -> Self {
static func stub(_ title: ScenarioTitle) -> Self {
SearchedData(
category: "Category",
scenario: .stub("Scenario \(index)"),
scenario: .stub(title),
highlightRange: nil
)
}
}

extension SearchedCategoryData {
static func stub(
scenarios: [SearchedData] = (0..<3).map { .stub($0) }
scenarios: [SearchedData] = (0..<3).map { .stub("Scenario \($0)") }
) -> Self {
SearchedCategoryData(
category: "Category",
Expand Down