Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Script Re-exports #8

Merged
merged 6 commits into from
Jan 23, 2025
Merged

Support Script Re-exports #8

merged 6 commits into from
Jan 23, 2025

Conversation

marklundin
Copy link
Member

@marklundin marklundin commented Sep 6, 2024

For completeness, this PR adds support for parsing re-exported scripts. This allows things like

export { CameraFrame } from 'playcanvas/scripts/esm/camera-frame.mjs';
export { CameraControls } from 'playcanvas/scripts/esm/camera-controls.mjs';

Includes tests

@marklundin marklundin requested a review from kpal81xd September 6, 2024 11:17
src/index.js Outdated Show resolved Hide resolved
test/tests/valid/export.test.js Outdated Show resolved Hide resolved
Co-authored-by: KPal <48248865+kpal81xd@users.noreply.github.com>
@marklundin marklundin requested review from kpal81xd and removed request for kpal81xd September 13, 2024 14:26
@marklundin marklundin merged commit 3059740 into main Jan 23, 2025
1 check passed
@marklundin marklundin deleted the feat-export-as branch January 23, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants