Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BoundingBox, BoundingSphere, OrientedBox extra methods. #858

Open
Maksims opened this issue Feb 22, 2017 · 2 comments
Open

BoundingBox, BoundingSphere, OrientedBox extra methods. #858

Maksims opened this issue Feb 22, 2017 · 2 comments
Labels
feature good first issue Good for newcomers

Comments

@Maksims
Copy link
Collaborator

Maksims commented Feb 22, 2017

It worth finalizing consistency withing those three classes, so here is list of things to do:

BoundingBox

  1. Deprecate intersects and add another method intersectsBoundingBox which will have same functionality
  2. Add intersectsOrientedBox method
  3. Add center and halfExtents property reference

BoundingSphere

  1. Add intersectsBoundingBox method (calls box.intersectsBoundingSphere internally)
  2. Add intersectsOrientedBox method
  3. Add center and radius property reference

OrientedBox

  1. Add intersectsBoundingBox method (calls box.intersectsOrientedBox internally)
  2. Add intersectsOrientedBox method
  3. Add halfExtents property reference
  4. Property worldTransform has wrong reference
@Maksims Maksims added the good first issue Good for newcomers label Mar 7, 2017
@OmarShehata
Copy link
Contributor

Is there any special process for deprecating a function @Maksims ? Is it just adding @deprecated in the comment block above it?

@willeastcott
Copy link
Contributor

This is a good example.

steven65816 pushed a commit to steven65816/engine that referenced this issue Apr 10, 2018
BoundingBox, BoundingSphere, OrientedBox extra methods. (playcanvas#858)
29ec0dd 
BoundingBox
-Deprecated intersects() and added intersectsBoundingBox() method
-Added intersectsOrientedBox() method
-Added center and halfExtents properties

BoundingSphere
-Added intersectsBoundingBox() method
-Added intersectsOrientedBox() method
-Added center and radius properties

OrientedBox
-Added intersectsBoundingBox() method
-Added intersectsOrientedBox() method
-Added halfExtents property and updated worldTransform property
@steven65816 steven65816 mentioned this issue Apr 10, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BoundingBox, BoundingSphere, OrientedBox extra methods. (#858) steven65816/engine
4 participants
@Maksims @willeastcott @OmarShehata @yaustar