Debug primitive drawing API #1875
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th duration, depth test, layer controls. (#1852) - new DebugDraw with advanced debug primitive rendering - added static constant colors in Color class - improved low level line rendering to handle depth testing better - DebugDraw engine example
willeastcott
changed the title
slimbuck
reviewed
Feb 14, 2020
| var i; | ||
| for (i = 0; i < lines.length; i++) { | ||
| if (lines[i].isAlive) { | ||
| pc.app._addLines(lines[i].points, lines[i].colors, lines[i].options); |
There was a problem hiding this comment.
App doesn't have an _allLines function... what am I missing?!
There was a problem hiding this comment.
it's in immediate.js
There was a problem hiding this comment.
Eeeeuw immediate assigns to Application.prototype! (mindblownemoji)
There was a problem hiding this comment.
Yeah, this could definitely do with being tidied up. I don't think it's necessary for this PR to address this problem though. But @mvaligursky, maybe add an issue to refactor this part of the engine?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added public DebugDraw interface for rendering of debug primitives with duration, depth test, layer controls.
Fixes #1852