Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] null access when pushing SpectorJS marker without camera #1933

Merged
merged 1 commit into from
Mar 25, 2020
Merged

[FIX] null access when pushing SpectorJS marker without camera #1933

merged 1 commit into from
Mar 25, 2020

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Mar 25, 2020 •
edited
Loading

Fixes #1932

@mvaligursky mvaligursky self-assigned this Mar 25, 2020
@mvaligursky mvaligursky requested a review from a team March 25, 2020 09:31
@willeastcott willeastcott merged commit 9b4a312 into master Mar 25, 2020
@willeastcott willeastcott deleted the mvaligursky-spectorjs-fix branch March 25, 2020 09:32
@willeastcott willeastcott changed the title Fix to null access when pushing SpectorJS marker without camera [FIX] null access when pushing SpectorJS marker without camera Mar 25, 2020
TheJonRobinson added a commit to Mojiworks/playcanvas-engine that referenced this pull request Mar 30, 2020
@TheJonRobinson
Merge branch 'stable' into mojiworks/master
67a1975 
* stable: (48 commits)
  [RELEASE] v1.26.0
  [FIX] null access when pushing SpectorJS marker without camera (playcanvas#1933)
  [FIX] pc.XrHitTest when WebXR not available
  Update package-lock.json
  Downgrade mocha to 6.2.2
  WebXR AR hit test support (playcanvas#1926)
  [ImgBot] Optimize images (playcanvas#1927)
  [DOCS] Make anim API private (playcanvas#1924)
  Update NPM dependencies.
  [FIX] Update some example paths
  Update to latest JSDoc template
  [FIX] Updating of particle systems local bounds
  Add pc.drawTexture to render texture to target using a shader (playcanvas#1920)
  Optimize Grab-Pass for WebGL 2 and fix when using anti-aliased RenderTarget (playcanvas#1918)
  [DOCS] Document drawQuadWithShader and copyRenderTarget (playcanvas#1919)
  [FIX] Mouse wheel events on elements (playcanvas#1916)
  glTF 2.0 support (playcanvas#1904)
  Update to latest JSDoc template.
  Add support for ES6 script classes (playcanvas#1908)
  Particle system randomize sprite animations (playcanvas#1911)
  ...
ellthompson pushed a commit to ellthompson/engine that referenced this pull request Apr 20, 2020
@mvaligursky
[FIX] null access when pushing SpectorJS marker without camera (playc…
e10ad6f 
…anvas#1933)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willeastcott willeastcott willeastcott approved these changes

Assignees

@mvaligursky mvaligursky

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Debug engine throws exception when layer has no camera
2 participants
@mvaligursky @willeastcott