Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GSplat shader fixes #7283

Merged
merged 1 commit into from
Jan 16, 2025
Merged

GSplat shader fixes #7283

merged 1 commit into from
Jan 16, 2025

Conversation

slimbuck
Copy link
Member

This shader fixes a few issues:

  • use consistent texture naming between rendering 2 or 3 bands of spherical harmonics
    • having different naming is an issue when 3 bands of spherical harmonics are loaded but only 2 are used for rendering
  • Fix invalid initCenter call
  • Small asset type update

@slimbuck slimbuck added bug area: graphics Graphics related issue labels Jan 16, 2025
@slimbuck slimbuck requested a review from a team January 16, 2025 08:40
@slimbuck slimbuck self-assigned this Jan 16, 2025
@slimbuck slimbuck merged commit f037ad2 into playcanvas:main Jan 16, 2025
7 checks passed
@slimbuck slimbuck deleted the shader-dev branch January 16, 2025 08:44
mvaligursky pushed a commit that referenced this pull request Jan 17, 2025
@slimbuck
GSplat shader fixes (#7283)
57f7af5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvaligursky mvaligursky mvaligursky approved these changes

Assignees

@slimbuck slimbuck

Labels
area: graphics Graphics related issue bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slimbuck @mvaligursky