Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When Texture.srgb is changed, shaders are reevaluated to be recreated #7336

Merged
merged 1 commit into from
Feb 7, 2025
Merged

When Texture.srgb is changed, shaders are reevaluated to be recreated #7336

merged 1 commit into from
Feb 7, 2025

Conversation

mvaligursky
Copy link
Contributor

  • this is depended on by the Editor’s inspector, when the srgb property of the texture changes. Shaders need to be updated to respect new texture encoding.

@mvaligursky mvaligursky self-assigned this Feb 7, 2025
@mvaligursky mvaligursky added area: graphics Graphics related issue enhancement labels Feb 7, 2025
@mvaligursky mvaligursky requested a review from a team February 7, 2025 10:57
@willeastcott willeastcott changed the title When Texture.srgb is changed, shaders are reevaluated to be recreateed When Texture.srgb is changed, shaders are reevaluated to be recreated Feb 7, 2025
@mvaligursky mvaligursky merged commit 9fbd67d into main Feb 7, 2025
7 checks passed
@mvaligursky mvaligursky deleted the mv-srgb-shader-rebuild branch February 7, 2025 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slimbuck slimbuck slimbuck approved these changes

Assignees

@mvaligursky mvaligursky

Labels
area: graphics Graphics related issue enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvaligursky @slimbuck