Refactored view parser into plugin decomposition

.circleci/config.yml

@@ -535,4 +535,4 @@ workflows:
           requires:
             - android_test
             - coverage
-            - build_ios
+            - build_ios

core/player/src/plugins/default-view-plugin.ts

@@ -1,6 +1,8 @@
 import type { Player, PlayerPlugin } from "../player";
 import {
   ApplicabilityPlugin,
+  AssetPlugin,
+  MultiNodePlugin,
   StringResolverPlugin,
   SwitchPlugin,
   TemplatePlugin,
@@ -17,12 +19,14 @@ export class DefaultViewPlugin implements PlayerPlugin {
     player.hooks.viewController.tap(this.name, (viewController) => {
       viewController.hooks.view.tap(this.name, (view) => {
         const pluginOptions = toNodeResolveOptions(view.resolverOptions);
+        new AssetPlugin().apply(view);
         new SwitchPlugin(pluginOptions).apply(view);
         new ApplicabilityPlugin().apply(view);
         new StringResolverPlugin().apply(view);
         const templatePlugin = new TemplatePlugin(pluginOptions);
         templatePlugin.apply(view);
         view.hooks.onTemplatePluginCreated.call(templatePlugin);
+        new MultiNodePlugin().apply(view);
       });
     });
   }

core/player/src/view/__tests__/view.immutable.test.ts

@@ -3,7 +3,12 @@ import { LocalModel, withParser, PipelinedDataModel } from "../../data";
 import { ExpressionEvaluator } from "../../expressions";
 import { BindingParser } from "../../binding";
 import { SchemaController } from "../../schema";
-import { ApplicabilityPlugin, StringResolverPlugin, ViewInstance } from "..";
+import {
+  ApplicabilityPlugin,
+  AssetPlugin,
+  StringResolverPlugin,
+  ViewInstance,
+} from "..";
 import { NodeType } from "../parser";
 
 const parseBinding = new BindingParser().parse;
@@ -34,6 +39,7 @@ test("uses the exact same object if nothing changes", () => {
   );
 
   new StringResolverPlugin().apply(view);
+  new AssetPlugin().apply(view);
 
   view.hooks.resolver.tap("input", (resolver) => {
     resolver.hooks.resolve.tap("input", (value, astNode, options) => {
@@ -205,6 +211,7 @@ test("hardcore immutability", () => {
   );
 
   new StringResolverPlugin().apply(view);
+  new AssetPlugin().apply(view);
 
   const resolved = view.update();
 

core/player/src/view/__tests__/view.test.ts

@@ -4,6 +4,7 @@ import { ExpressionEvaluator } from "../../expressions";
 import { BindingParser } from "../../binding";
 import { SchemaController } from "../../schema";
 import {
+  MultiNodePlugin,
   StringResolverPlugin,
   SwitchPlugin,
   ViewInstance,
@@ -122,6 +123,7 @@ describe("view", () => {
 
       const pluginOptions = toNodeResolveOptions(view.resolverOptions);
       new SwitchPlugin(pluginOptions).apply(view);
+      new MultiNodePlugin().apply(view);
       new StringResolverPlugin().apply(view);
 
       const resolved = view.update();
@@ -381,6 +383,7 @@ describe("view", () => {
 
       const pluginOptions = toNodeResolveOptions(view.resolverOptions);
       new SwitchPlugin(pluginOptions).apply(view);
+      new MultiNodePlugin().apply(view);
       new StringResolverPlugin().apply(view);
 
       const resolved = view.update();
@@ -735,6 +738,7 @@ describe("view", () => {
 
       const pluginOptions = toNodeResolveOptions(view.resolverOptions);
       new SwitchPlugin(pluginOptions).apply(view);
+      new MultiNodePlugin().apply(view);
       new StringResolverPlugin().apply(view);
 
       const resolved = view.update();

core/player/src/view/parser/__tests__/parser.test.ts

@@ -3,7 +3,13 @@ import { BindingParser } from "../../../binding";
 import { LocalModel, withParser } from "../../../data";
 import { SchemaController } from "../../../schema";
 import { NodeType, Parser } from "../index";
-import { SwitchPlugin, ApplicabilityPlugin, TemplatePlugin } from "../..";
+import {
+  SwitchPlugin,
+  ApplicabilityPlugin,
+  TemplatePlugin,
+  MultiNodePlugin,
+  AssetPlugin,
+} from "../..";
 import type { Options } from "../../plugins/options";
 import { ExpressionEvaluator } from "../../../expressions";
 import type { DataModelWithParser } from "../../../data";
@@ -30,9 +36,11 @@ describe("generates the correct AST", () => {
         model,
       },
     };
+    new AssetPlugin().applyParser(parser);
     new TemplatePlugin(options).applyParser(parser);
     new ApplicabilityPlugin().applyParser(parser);
     new SwitchPlugin(options).applyParser(parser);
+    new MultiNodePlugin().applyParser(parser);
   });
 
   test("works with basic objects", () => {
@@ -154,8 +162,10 @@ describe("parseView", () => {
         model,
       },
     };
+    new AssetPlugin().applyParser(parser);
     new TemplatePlugin(options).applyParser(parser);
     new ApplicabilityPlugin().applyParser(parser);
+    new MultiNodePlugin().applyParser(parser);
     new SwitchPlugin(options).applyParser(parser);
   });
 
@@ -249,8 +259,13 @@ describe("generates the correct AST when using switch plugin", () => {
       return true;
     },
   } as any);
+  const multiNodePlugin = new MultiNodePlugin();
+  const assetPlugin = new AssetPlugin();
+
   const parser = new Parser();
   switchPlugin.applyParser(parser);
+  multiNodePlugin.applyParser(parser);
+  assetPlugin.applyParser(parser);
 
   test("works with asset wrapped objects", () => {
     expect(parser.parseObject(toughStaticSwitchView)).toMatchSnapshot();