Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose More Information About Expression Parsing Errors #328

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

KetanReddy
Copy link
Member

@KetanReddy KetanReddy commented Apr 2, 2024

Change Type (required)

Indicate the type of change your pull request is:

  • patch
  • minor
  • major

Release Notes

Types - Expose types/utilities around expression parsing errors

Does your PR have any documentation updates?

  • Updated docs
  • No Update needed
  • Unable to update docs

Version

Published prerelease version: 0.7.2-next.4

Changelog

Release Notes

Expose More Information About Expression Parsing Errors (#328)

Types - Expose types/utilities around expression parsing errors

Does your PR have any documentation updates?

  • Updated docs
  • No Update needed
  • Unable to update docs

Fix commaNumber Formatting when Using a Precision of 0 (#319)

Common Types Plugin - Fix commaNumber Formatting when Using a Precision of 0

Expression Parser Strictness (#315)

Expose Expression Parser's strictness option via the resolveOptions hook


🐛 Bug Fix

📝 Documentation

Authors: 7

@KetanReddy KetanReddy added the patch Increment the patch version when merged label Apr 2, 2024
@KetanReddy KetanReddy requested a review from a team April 2, 2024 17:17
@KetanReddy KetanReddy self-assigned this Apr 2, 2024
@KetanReddy KetanReddy requested a review from adierkens as a code owner April 2, 2024 17:17
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 81.90%. Comparing base (9c00884) to head (df973cd).
Report is 6 commits behind head on main.

Files Patch % Lines
core/player/src/expressions/utils.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #328      +/-   ##
==========================================
- Coverage   81.93%   81.90%   -0.04%     
==========================================
  Files         133      133              
  Lines        4617     4619       +2     
  Branches     1141     1142       +1     
==========================================
  Hits         3783     3783              
- Misses        553      555       +2     
  Partials      281      281              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KetanReddy KetanReddy merged commit 1249770 into main Apr 3, 2024
9 of 11 checks passed
@KetanReddy KetanReddy deleted the export-expression-parser-types branch April 3, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants