Bazel 6 async node plugin ios updates #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nancywu1
changed the title
hborawski
requested changes
Apr 25, 2024
ios/README.md
Outdated
| @@ -133,6 +133,16 @@ The `name` passed into `ios_plugin` or `swiftui_plugin` is prefixed with `Player | |||
| ios_plugin(name = "ExamplePlugin") | |||
| ``` | |||
|
|
|||
| for iOS Plugins the js_pipeline for the core plugin should have `native_bundle` should be set to `ExamplePlugin` to match the `name` in the ios_plugin | |||
There was a problem hiding this comment.
Suggested change
| for iOS Plugins the js_pipeline for the core plugin should have `native_bundle` should be set to `ExamplePlugin` to match the `name` in the ios_plugin | |
| For iOS plugins the `js_pipeline` for the core plugin should have `native_bundle` should be set to `ExamplePlugin` to match the `name` in the ios_plugin |
hborawski
approved these changes
Apr 26, 2024
hborawski
approved these changes
Apr 26, 2024
Co-authored-by: Harris Borawski <harrisborawski@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Type (required)
Indicate the type of change your pull request is:
patchminormajorDoes your PR have any documentation updates?