Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This PR fixes the Ability to resolve with nothing issue #389
This PR fixes the Ability to resolve with nothing issue #389
Changes from 3 commits
1392aeb
43f2f52
c6fe4ec
4db7c64
c6654aa
3d04e73
4ac041d
00d9835
d650759
1040138
ec4eba7
797765d
af64f0d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This plugin, if registered, will live as long as the player instance it's registered to is still active.
That means as we repeated update UI, this check will only be true once.
I'm not 100% sure your original solution won't work, i'd write some tests to make sure the solution is okay through multiple updates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed the business logic to such the node is resolved irrespective of the type which ensures that the consumer can expect the node to be resolved irrespective of the input they provide us with. Also updated respective test case such that we ensure nothing is resolved and also that the resolution happens only once and after the promise has been resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should check that returning the same async node doesn't impact future updates, I think you could do so by manually calling the
update
function in the resolver, see what happens if you try to update again after the resolve withnull
/undefined
has been processedThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you're not looking at the updated code .. This is the updated code