Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert async node flatten #512

Merged
merged 5 commits into from
Sep 24, 2024
Merged

revert async node flatten #512

merged 5 commits into from
Sep 24, 2024

Conversation

cehan-Chloe
Copy link
Collaborator

@cehan-Chloe cehan-Chloe commented Sep 20, 2024

  1. Revert flatten nested node change
  2. update tests for all platforms

Change Type (required)

Indicate the type of change your pull request is:

  • patch
  • minor
  • major

Does your PR have any documentation updates?

  • Updated docs
  • No Update needed
  • Unable to update docs

Version

Published prerelease version: 0.9.1-next.2

Changelog

🐛 Bug Fix

Authors: 5

@brocollie08
Copy link
Contributor

might need to change test on other platforms too

@cehan-Chloe cehan-Chloe marked this pull request as ready for review September 24, 2024 15:46
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.84%. Comparing base (12b4867) to head (870606d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #512      +/-   ##
==========================================
+ Coverage   91.88%   92.84%   +0.95%     
==========================================
  Files         341      341              
  Lines       27237    27232       -5     
  Branches     1945     1944       -1     
==========================================
+ Hits        25028    25284     +256     
+ Misses       2195     1948     -247     
+ Partials       14        0      -14     
Flag Coverage Δ
92.84% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brocollie08 brocollie08 added the patch Increment the patch version when merged label Sep 24, 2024
@brocollie08 brocollie08 merged commit a3d9959 into main Sep 24, 2024
11 checks passed
@brocollie08 brocollie08 deleted the revert-async-node-flatten branch September 24, 2024 18:37
@intuit-svc intuit-svc mentioned this pull request Sep 26, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants