Use one and only CONTRIBUTING file #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkurz
commented
Oct 20, 2022
|
|
||
| ### Procedure | ||
|
|
||
| 1. Make sure you have signed the [Lightbend CLA](https://www.lightbend.com/contribute/cla); if not, sign it online. | ||
| 2. Ensure that your contribution meets the following guidelines: | ||
| <!--- 1. Make sure you have signed the [XXX CLA](https://www.example.com/contribute/cla); if not, sign it online. --> |
There was a problem hiding this comment.
We can uncomment that later in case needed.
This was referenced Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we have a couple of contributor guidles, some of them are very very outdate, most of themhowever are quite similiar - but not the same:
So I diffed all of them and merged them into one, trying to be as general as possible, but also mentioning special cases like the anorm and play-soap project.
I think it's fine.
If someone wants to change something pull requests welcome.
I will also link to this document from the website.