New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create common SBT settings with aliases for format/validate code #55

Merged

ihostage merged 1 commit into main from sbt-common

Jan 25, 2023

Member

ihostage commented Oct 26, 2022 •

edited

Loading

Related to playframework/play-meta#252

Member

mkurz commented Oct 26, 2022

Wait....
What if a repo needs to run special commands: https://github.com/playframework/playframework/blob/a83c8cb39d95c3e31b03b01a693fd1a5c0d9f24a/build.sbt#L491
?

ihostage force-pushed the sbt-common branch from fdad030 to 9d1c53e Compare

October 26, 2022 14:17

Member Author

ihostage commented Oct 26, 2022

Hmmm 🤔 Just don't sync this file with this repo? 🤷‍♂️

Member Author

ihostage commented Oct 26, 2022

Test PR playframework/play-soap#328

Member Author

ihostage commented Oct 26, 2022

@mkurz or we can create a special version for some repository, I don't think that it's a problem.
For example for main Play repo we need to sync common.sbt with two branches (main, 2.8.x) as minimum. So it will already make sense 😄

Member

mkurz commented Nov 8, 2022

or we can create a special version for some repository, I don't think that it's a problem.

@ihostage OK, then lets do it that way 👍

ihostage force-pushed the sbt-common branch from 9d1c53e to 3d93761 Compare

November 9, 2022 09:40

mkurz reviewed

View reviewed changes

sbt/common.sbt Outdated Show resolved Hide resolved

ihostage force-pushed the sbt-common branch 2 times, most recently from 699b1c9 to 3d9455e Compare

November 9, 2022 13:43

ihostage mentioned this pull request

implements #11467. Adds command to fix up formats playframework/playframework#11513

Merged

7 tasks

mkurz reviewed

View reviewed changes

sbt/common.sbt Outdated Show resolved Hide resolved

mkurz reviewed

View reviewed changes

sbt/common.sbt Outdated Show resolved Hide resolved

ihostage force-pushed the sbt-common branch from 3d9455e to 3192878 Compare

January 25, 2023 09:23

ihostage marked this pull request as ready for review

January 25, 2023 09:28

ihostage requested a review from mkurz

January 25, 2023 09:28

ihostage commented

View reviewed changes

sbt/common.sbt Outdated

Comment on lines 8 to 13

+              /**
+               * If you need an extra commands to format source code, add the next code to your `build.sbt`
+               * {{{
+               *   val _ = sys.props += ("sbt_formatCode" -> List(...).mkString(";"))
+               * }}}
+               */

Member Author

ihostage Jan 25, 2023

@mkurz If you agree with this comment and below, I will add a synchronization with main Play repo and merge it.

Member

mkurz Jan 25, 2023 •

edited

Loading

Sure! Maybe it's also possible to sync the files into the Play repo's ./documentation/ folder?

Member Author

ihostage Jan 25, 2023

Yes, it's possible, I'll do that 😉

Member Author

ihostage Jan 25, 2023

Done ✔️

Member Author

ihostage Jan 25, 2023

playframework/playframework#11631

mkurz reviewed

View reviewed changes

sbt/common.sbt Outdated Show resolved Hide resolved

mkurz reviewed

View reviewed changes

sbt/common.sbt Outdated Show resolved Hide resolved

ihostage force-pushed the sbt-common branch 2 times, most recently from e40a9bb to 19774f5 Compare

January 25, 2023 10:06


          Create common SBT settings with aliases for format/validate code

4de7f12

ihostage force-pushed the sbt-common branch from 19774f5 to 4de7f12 Compare

January 25, 2023 11:26

ihostage merged commit feeec59 into main

ihostage deleted the sbt-common branch

January 25, 2023 11:31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet