Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare anorm-docs project for Scala 3 #537

Merged
merged 11 commits into from
Aug 12, 2024

Conversation

mkurz
Copy link
Member

@mkurz mkurz commented Mar 1, 2023

This way the "Dependency Graph" workflow should become green as soon as we release a Play 2.9 version / milestone with Scala 3 artifacts: https://github.com/playframework/anorm/actions/workflows/dependency-graph.yml

@mkurz mkurz force-pushed the prepare-anorm-docs-scala3 branch 2 times, most recently from 24b9198 to aaafd90 Compare March 1, 2023 23:19
@mkurz
Copy link
Member Author

mkurz commented Apr 12, 2023

@cchantep whenevery you have time, can you take a look at the error when docs get compiled with Scala 3?

[error] -- Error: /home/runner/work/anorm/anorm/docs/manual/working/scalaGuide/main/sql/code/MacroToParameters.scala:60:28 
[error] 60 |    Macro.toParameters("#", Macro.ParameterProjection("bar", "lorem"))
[error]    |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[error]    | Expected a known value. 
[error]    |
[error]    | The value of: projection$proxy3
[error]    | could not be extracted using scala.quoted.FromExpr$SeqFromExpr@4bfe502c
[error] one error found
[error] (docs / Test / compileIncremental) Compilation failed

I don't want to spent too much time with anorm right now so would be happy if you check. Thanks!

@cchantep cchantep force-pushed the prepare-anorm-docs-scala3 branch from 87c4a1c to 7172d4b Compare April 13, 2023 15:43
@cchantep
Copy link
Member

@cchantep whenevery you have time, can you take a look at the error when docs get compiled with Scala 3?

[error] -- Error: /home/runner/work/anorm/anorm/docs/manual/working/scalaGuide/main/sql/code/MacroToParameters.scala:60:28 
[error] 60 |    Macro.toParameters("#", Macro.ParameterProjection("bar", "lorem"))
[error]    |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[error]    | Expected a known value. 
[error]    |
[error]    | The value of: projection$proxy3
[error]    | could not be extracted using scala.quoted.FromExpr$SeqFromExpr@4bfe502c
[error] one error found
[error] (docs / Test / compileIncremental) Compilation failed

I don't want to spent too much time with anorm right now so would be happy if you check. Thanks!

Need to split code2 / code3 for ScalaAnorm ...

@mkurz mkurz force-pushed the prepare-anorm-docs-scala3 branch from 7172d4b to 0cbfd75 Compare September 11, 2023 21:22
@ihostage
Copy link
Member

Hi, @cchantep! Can you finish this PR to release a final version Anorm that supports a pekko-stream (#572)?

@gaeljw
Copy link
Member

gaeljw commented Nov 28, 2023

Can we help somehow to move forward a release including pekko-stream support?

@mkurz mkurz force-pushed the prepare-anorm-docs-scala3 branch from 0cbfd75 to 8bf0efe Compare March 12, 2024 16:16
@mkurz mkurz force-pushed the prepare-anorm-docs-scala3 branch from 8bf0efe to 2bcf9ef Compare March 12, 2024 16:20
@mkurz
Copy link
Member Author

mkurz commented Mar 12, 2024

Can we help somehow to move forward a release including pekko-stream support?

@gaeljw (or whoever wants to help) you could take this pull request as base and try to get things work, also see hints in #537 (comment)

Currently, I will not spend time on this pull request, so community help is desired.

@cchantep cchantep force-pushed the prepare-anorm-docs-scala3 branch 6 times, most recently from 8ef8ba2 to 0e3e72f Compare August 12, 2024 16:22
@cchantep cchantep force-pushed the prepare-anorm-docs-scala3 branch from 0e3e72f to 0455f15 Compare August 12, 2024 20:25
@cchantep cchantep merged commit 8ffe87f into playframework:main Aug 12, 2024
1 check passed
@mkurz mkurz deleted the prepare-anorm-docs-scala3 branch November 17, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants