Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release reference to HttpStreamsServerHandler.lastRequest when possible #161

Merged
merged 1 commit into from
Oct 12, 2022
Merged

Release reference to HttpStreamsServerHandler.lastRequest when possible #161

merged 1 commit into from
Oct 12, 2022

Commits on Oct 12, 2022

  1. Release reference to HttpStreamsServerHandler.lastRequest when possible 

    When using idleTimeout configuration in a play application, the
HttpStreamsServerHandler keeps a reference to lastRequest, and
lastRequest can be relatively large (10kb).  When there are many open
idle connections, lastRequest heap usage can add up, even though the
data is not used (lastRequest will be reassigned to a new value when
serving the next request).

This change sets lastRequest to null to allow the HttpRequest to be GC'd
even if HttpStreamsServerHandler is kept in the heap.
    @georgepearman
    georgepearman committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    42a8b46 View commit details
    Browse the repository at this point in the history