Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross build against Scala 2.12 because it's need by a sbt-plugin #154

Merged
merged 1 commit into from
Sep 30, 2022

Conversation

mkurz
Copy link
Member

@mkurz mkurz commented Sep 30, 2022

The project is defined as interplay PlayLibrary, which however dropped Scala 2.12, because a PlayLibrary is meant to be used for libraries not for plugins. But play-doc is also used for an sbt-plugin, so we need to explicitly build for 2.12. (And yes I know interplay should be gone soon)

The project is defined as interplay PlayLibrary, which however dropped
Scala 2.12, because a PlayLibrary is meant to be used for libraries
not for plugins. So we need to explicitly build for 2.12.
@mkurz
Copy link
Member Author

mkurz commented Sep 30, 2022

That's were interplay removed cross building against 2.12 for the PlayLibrary plugin: playframework/interplay#176

@mkurz mkurz merged commit a5bdaf0 into playframework:main Sep 30, 2022
@mkurz mkurz deleted the 2.12-crossbuild branch September 30, 2022 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant