Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show all imports required to compile example code #416

Merged
merged 3 commits into from
May 18, 2020
Merged

Show all imports required to compile example code #416

merged 3 commits into from
May 18, 2020

Conversation

yoohaemin
Copy link
Contributor

Pull Request Checklist

Fixes

n/a

Purpose

Sample code does not compile by itself. Show all imports needed to compile.

Background Context

n/a

References

n/a

required import `play.api.libs.functional.syntax._` not shown in the doc
@cchantep
Copy link
Member

Hi, I agree with the goal, but there the import is only visible for one of the code examples, not all that require it (not really consistent).

Copy link
Contributor

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mergify mergify bot merged commit 0271496 into playframework:master May 18, 2020
@ennru
Copy link
Contributor

ennru commented May 18, 2020

Thank you. Finding the correct import is hard at times...

@ennru
Copy link
Contributor

ennru commented May 18, 2020

@Mergifyio backport 2.8.x

@mergify
Copy link
Contributor

mergify bot commented May 18, 2020

Command backport 2.8.x: success

Backports have been created

mergify bot added a commit that referenced this pull request May 18, 2020
Show all imports required to compile example code (bp #416)
@yoohaemin yoohaemin deleted the patch-1 branch May 19, 2020 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants