Travis: use stages #469
Travis: use stages #469
Conversation
.travis.yml
Outdated
| - stage: publish | ||
| name: "TEMPORARY, will become Publish artifacts to Bintray" | ||
| script: sbt +mimaReportBinaryIssues | ||
| scala: 2.13.1 |
There was a problem hiding this comment.
why do we need the scala version?
There was a problem hiding this comment.
Otherwise the Travis Matrix kicks in and runs it for 2.12 and 2.13.
There was a problem hiding this comment.
I think you lost me? Are you saying that the scala section on line 13 will cause it to run twice?
I think we should remove this. The build.sbt already define the default scala version and the the + will take care of the cross building.
Btw, play-soap doesn't have it: https://github.com/playframework/play-soap/blob/master/.travis.yml
There was a problem hiding this comment.
We don't have a definition for state test in this file? Is that a default staget? And will it pick what is defined in script (line 20)?
There was a problem hiding this comment.
Play SOAP doesn't use a Travis Matrix.
Yes, test automatically inherits the global script as it doesn't have its own.
There was a problem hiding this comment.
That was my point. I was suggesting to remove the mix of matrix with stages. Let's only have stages, otherwise we need extra brain cycles to map the effect they have on each other.
|
What's the motivation behind the matrix unroll? Easier to grok? Easier to vary things for different versions (at the expense of consistency)? |
|
Easier to grok, fewer WTFs, see what is there. |
|
Gotcha. Btw, I just remembered, there's also https://config.travis-ci.com/explore to help understand the matrix expansion as well as other details. |
Introduce stages to test first, publish after it