-
-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade jackson to latest compatible with play 2.8.x framework #660
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@nimatrueway, I just realised that the master branch of this project is already using Jackson 2.11.4 and that you sent a PR to the 2.8.x branch. Any reason why are you still on version 2.8 of play-json? I don't think we will cut a new release for 2.8.x branch. It's easier to move to 2.9 instead. Also, Play 2.8 does use play-json 2.9.2 and Jackson 2.11.4. |
Dismissing my own approval as I don't think we will cut a new release of 2.8.x branch. Users should move to 2.9.2 instead.
@octonato if playframework releases a play 2.8.x that uses play-json 2.10.x then I agree that there is no justification for this PR. In current situation, other library developers, in order to address vulnerability audit alerts (that catch the outdated Jackson library pulled in as a dependency of play-json) have two choices:
We in Hootsuite are likely go with option 2 if this PR gets rejected, however I thought you folks could consider this as a safe patch update for play-json 2.8.x given the fact that playframework already overrides Jackson version and play-json still works fine. |
Hi! I am also strugling with some play/play-json/jackson/etc dependencies. I will fix it by overriding some jackson deps, but I think having a play-json 2.10.0 would also solve my problem. Any ETA for cutting a release? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll merge this one. Although I don't think we will cut a release from the 2.8.x branch, but we never now.
@jtjeferreira, no concrete plans, but I think I can cut the 2.10 release. It's just about creating a tag. |
It turns out that we end up cutting a release (2.8.2). I did it yesterday evening and it will be included in upcoming Play 2.8.10. Thanks @nimatrueway |
There is high-level vulnerability reported for jackson 2.10.x which this PR intends to address.
Play-framework 2.8.8 already pulls in Jackson library version 2.11.4 on top of play-json 2.8.1 (overrides jackson version in the application), so a testament that play-json 2.8.1 is already compatible with Jackson 2.11.4.