New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#2066] avoid NPE in regex matcher #1022

Merged

xael-fry merged 1 commit into playframework:master from flybyray:lighthouse-2066-patch

Nov 11, 2016

Contributor

flybyray commented Nov 5, 2016

I think it is enough to check only once for null before calling the regex matcher.

This fix is needed if you really use "open file from errors pages" (a Play! developer feature):

# Open file from errors pages
# ~~~~~
# If your text editor supports opening files by URL, Play! will
# dynamically link error pages to files 
#
# Example, for textmate:
# play.editor=txmt://open?url=file://%s&line=%s

Here is a nice summary how to use it with several os: How open files in ide from debugger


          avoid NPE in regex matcher

17092f9

xael-fry merged commit 6061c12 into playframework:master

Member

xael-fry commented Nov 11, 2016

Merged and pushed in master and 1.4.x
Thanks

xael-fry added this to the 1.4.4 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet