Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#2170] Action context access from error templates #1230

Merged
merged 4 commits into from
Aug 23, 2018
Merged

[#2170] Action context access from error templates #1230

merged 4 commits into from
Aug 23, 2018

Conversation

sant0s
Copy link
Contributor

@sant0s sant0s commented Apr 30, 2018

This fix restores action context access from error templates by intitialising the action context during the action resolution phase.

@sant0s sant0s force-pushed the lighthouse-2170-patch branch from cb1477e to 3f4cd4d Compare July 26, 2018 12:51
@sant0s sant0s mentioned this pull request Jul 26, 2018
Merged
@asolntsev asolntsev self-requested a review July 27, 2018 22:42
asolntsev
asolntsev approved these changes Jul 27, 2018
View reviewed changes
Copy link
Contributor

@asolntsev asolntsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xael-fry This PR is ok. It fixes an issues introduced in commit defbe30.

Recommended to merge.

@xael-fry xael-fry added this to the 1.5.2 milestone Aug 23, 2018
@xael-fry xael-fry merged commit 7d7a73e into playframework:master Aug 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asolntsev asolntsev asolntsev approved these changes

Assignees
No one assigned
Labels
defect
Projects
None yet
Milestone
1.5.2
Development

Successfully merging this pull request may close these issues.
4 participants
@sant0s @asolntsev @xael-fry @tomparle