Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2172] Apply NotFound result thrown during action resolution failure to response #1234

Closed
wants to merge 1 commit into from

Conversation

sant0s
Copy link
Contributor

@sant0s sant0s commented Apr 30, 2018

No description provided.

@sant0s
Copy link
Contributor Author

sant0s commented May 1, 2018

Although this change makes unavailable dynamic resources look (correctly) unavailable to functional tests (HTTP 404 is returned instead of HTTP 200), it breaks serving of valid/existing staticDir/staticFile ones (HTTP 404 is returned instead of HTTP 200).
Hopefully, a Play maintainer will be able to fix (Lighthouse) ticket 2172 so that correct REST-compliant HTTP responses are returned to functional tests in the same way they are returned to non-testing scenarios.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant