[#1763] Check for empty uploads when binding File[] #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am confused between master and the 1.3.x branch. Should I be submitting to the 1.3.x branch? |
|
play-1-3-x-pull-requests #114 SUCCESS |
|
All changes will end up in master and 1.3.x where possible and in 1.2.x if it is actually a bug... |
|
Sounds good. Thanks. Please let me know if you need more from this patch. |
pepite
added a commit
that referenced
this pull request
Jan 12, 2014
[#1763] Check for empty uploads when binding File[]
pepite
added a commit
that referenced
this pull request
Jan 12, 2014
[#1763] Check for empty uploads when binding File[]
flybyray
pushed a commit
to synapplix/play1
that referenced
this pull request
Jul 29, 2014
[#1763] Check for empty uploads when binding File[]
flybyray
pushed a commit
to synapplix/play1
that referenced
this pull request
Feb 15, 2015
[#1677] Fix not streaming SSE/EventSource in Chrome [#1677] Update to Netty V3.6.6 [#1677] Add tests for EventSource [#1750] Promise.get(timeout, unit) actually throws TimeoutExceptions [#1751] Avoid logger to format string to improve performance [#1754] add a way to tell user why the request was bad (clients of our webservice wanted messages of why the request was bad) [#1753] minor fix where : was not allowed in basic auth passwords breaking our customers.....passwords now can have colon with this fix [#1729] Fix Play status. keep search on field "sync" for openJDK Conflicts: framework/src/play/jobs/JobsPlugin.java [#1728] Use MySQL ping if apropriate, a SELECT 1 otherwise [#1748] Support custom MySQL driver parameters for "db" configuration parameter [#1760] make fields more visible so we can subclass Promise with our own unique promise to gain functionality [#1759] add exception log [#1735] Create TypeUnbinder in order to implement "unbind method" [#1735] Fix TypeUnbinder test the wrong class [#1735] add return to unbind method Issue #1774 - http://play.lighthouseapp.com/projects/57987/tickets/1774-dprecompiledtrue-not-using-precompiled-templates fixed. Precompiled templates and "routes" files from application and dependent modules used when Play! started with "-Dprecompiled=true" switch. All template sources ("app/views"and "modules/*/app/views" can be removed). Application "conf/routes" file cannot be removed because Python scripts check if it's present. "modules/*/conf/routes" files can be removed. For every file if there is no precompiled version available, source version will be used (id present). [#1656] fixed typo spotted by @gslowikowski Initial release DB support and introduced notion of filter (action method wrap around a filter). Documentation will follow. more work on the sample app more work on the sample app [playframework#781] simplify loading module, got rid of the moduleOrder.conf which is useless and instead use the depencies.yml which already define the right order [#1693] Non-zero exit code when evolutions fail backward compatibility [playframework#1036] Allow evolutions to be applied in a single transaction filter version number when retrieving list of modules only add modules Merge pull request playframework#707 from theo/lighthouse-1763-patch [#1763] Check for empty uploads when binding File[] Merge pull request playframework#690 from igmar/LH1749-fix-SSL-custom-keystores [#1749] fix ssl custom keystores fixed module dependencies [#1719] fix moduleOrder to handle Dynamic revisions and "id" options or with/without version number [#1719] Fix Configuration by adding jpa. and hibernate configuration * update ivy to version 2.3.0 [#1719] fix retrieving list of modules (filter lib, modules) [#1719] Add tests for retrieving modules [#1782] MultiDb configuration must contains "hibernate.xxx", "jpa.xxx" JPA : Add method isInitialized to detect if JPA is initialized JPA : define visibility to public for backward compatibility (local was public) [#1784] Fix Unbinder for collection to retrieve the correct type Updated Controller javadoc using renderBinary to stream content from an inputstream will fully load it into memory if no content-length is provided [#1790] fix Count to avoid infinite loop [#1785] Fix some resource leaks (close FileInputStream, or other object) * Code cleanup: Remove unused import [#1788] Fix Play is failing in SSL mode * MultiDb : add documentation for configuration * Fix exception on call of rollback [#1791] Unbind Map object with direct key [#1789] The host information of staticDir mappings are not ignored anymore [#1789] Update test (add some message if failed)for host information of staticDir [#1662] Evolutions down from modules remove all others evolutions (modules, application) [#1641] Fix MySQL specific statement used in evolutions table update code [playframework#1105] Fix again play_evolutions table creation for oracle db [#1641] Fix MySQL specific statement to use in evolutions * Fix I-am-a-developper to be able to run it on windows [#1662] Add the method resolve(int revision) for backward compatibility [#1776] First commit to handle multiDb evolutions [#1776] Indicate dbName in evolution exceptions [#1776] Add some documentation about multidb evolutions script naming Support Java 8. (Using "-noverify" option instead of "-XX:-UseSplitVerifier" - it works with both Java7 and Java8) fixing previous commit (binaries were corrupted, python import was deleted by IDEA) fixing previous commit (python import was deleted by IDEA again) [#1800] Remove unused javassist-3.15.0.GA.jar lib [#1800] Update dependencies.yml file [#1800] Update eclipsify command [#1800] Update compiler for support to java 8 [#1800] Update javadoc to link to Java8 [#1800] Add example for java8 [#1670] Restore delete ".travis.yml" Secure PLAY_ERRORS & PLAY_LANG cookies when session is secure [#1803] Added support for IPv6 IP address for the server code formatting and if not application.mode is defined, use the dev mode added missing file changed 1.3.0 release notes [#1766] fix for websocket dropping event (by blocking) - archivedEventStream will still have the dropped packets bug but will at least log that it drops packets Conflicts: framework/src/play/libs/F.java [#1679] IO.writeContent adds newline [playframework#385] Fix NoBinding and Fixtures : create a special profile for fixture to handle nobinding when loading fixtures [#1804] Fix NoBinding not working properly on entity, JPAPlugin must check the noBinding annotation [#1679] IO.writeContent adds newline - forgot one [#1806] Upsate to netty v3.9.0 [#1806] Up[date to async-http-client V1.8.8 added ability to specify which configurations you want to depend on [#1812] Better exit codes for evolutions Fix hibernate config pattern: underscore added (i.e. used in key "hibernate.ejb.naming_strategy") re-use content-type for files from Play response (if already set) [#1814] preserve order of HTTP GET/POST parameters - use LinkedHashMap [#1815] prevent XXE vulnerability in play.libs.XML and provide safe newDocumentBuilder() for applications [#1815] use safe DocumentBuilder in WS add another very useful getDocument() method that parses an InputStream [#1814] fix just-test-cases/RestTest [#1819] Update to Groovy V2.3.1 (without “invoke dynamic”) [#1819] Update to xtream V1.7.7 [#1809] Update to ASM V5.0.2, javaflow r 1590792, javassist 3.18.2-GA [#1824] Update to ANT v1.9.4 [#1824] Update to fest-util v1.2.5 [#1824] Update to mockito to v1.9.5 [#1824] Update to htmlunit V2.15 [#1824] Update to selenium V2.42 [#1824] Update to async-http-client-1.8.9 [#1824] Update to ehcache-core-2.6.9 [#1824] Update to h2-1.4.178 [#1824] Update to jamon-2.75 [#1824] Update to mysql-connector-java-5.1.30 [#1824] Update to netty-3.9.1.Final [#1824] Update to oval-1.84 [#1824] Update to slf4j 1.7.7 [#1824] Update to snakeyaml-1.13 [#1824] Update to spymemcached-2.10.3 [#1824] Restore fest-util-1.1.6 (need for fest-assert) [#1825] fix NPE in exception constructors when source files are not available (eg precompiled mode) Introduce base class for all exceptions trying to access Java source files - PlayExceptionWithJavaSource that fixes this issue for all exceptions that now extend it. [#1824] Fix dependencies.yml for spymemcached version [#1824] Restore to h2-1.3.176 as h2-1.4 make some tests failed (will be handle in different issues) updated english documentation to reflect dep management changes [#1827] build em factory after we have redefined Hibernate's classloader Otherwise Play doesn't start in precompiled mode with Hibernate throwing ClassNotFoundExceptions for entity classes. [#1811] Add some exception if configuration format is not correct Multi-db: change the log level of the DB used by models release notes [Documentation] Rename playframework.org URL to playframework.com [Documentation] Remove a rogue square bracket in cmd-start.txt [#1831] Fix transitive module loading [#1830] Upgrade to netty v3.9.2 because of security vulnerability * Update application-skel default java.source value to 1.6, as 1.5 is no longer supported [#1809] Add patch for javaflow * some code cleanup * [Dependencies] Fix dependencies version related to spymemcached * [Multi db] fix some misused of db properties [#1835] Use jpa.default.ddl instead of default.jpa.ddl [#1831] Fix loading modules for avoiding circular loading * [#1833] Fix driver not found exception [#1833] Remove the database migration for default db(avoid loop over configuration keys) [#1833] Fix retrieving properties "db.pool" for additional db [#1833] Fix jpql to create correct request considering the database Update cache.textile Conflicts: documentation/manual/cache.textile [#1843] Add validation-api-1.0.0.GA [#1843] Add hibernate-validator-4.1.0.Final Fix invalid links [#1845] Fix dataSource used for jndi connection Include trove 3.0.3 as dependency since it's required by oval 1.84 Updated Eclipse compiler to the one shipping with Luna, providing official Java 8 compilation support. The previous one didn't handle default methods correctly. JavaFlow fixes that include proper classloading when controllers with continuations rely on Play model classes Moved PopertiesEnhancer before ContinuationEnhancer, otherwise the Javassist seems to have trouble with the changed stack frames. Added patch for JavaFow classloader fix Wrong dependency version Renamed dependency so that Play can resolve it Removed unnecessary trove dependency [#1834] Restore "jpa.entities" and jpa.mapping-file properties [#1834] Add example to test jpa.entities * local connections weren't closed properly and none default ones were leaked * Fix executeQuery to get the correct connection * Fix exception when retrieving configuration [#1774] Add default method addModule / loadModules to assure backward-compatibility. Method Java.parameterNames re-throws original exception Avoid re-starting Play if it's already started (it happens if we run tests in "precompiled" mode) Fixed spelling error: "stRack trace" -> "stAck trace" (the old method PlayException.getInterestingStrackTraceElement is deprecated) Conflicts: framework/src/play/exceptions/CacheException.java framework/src/play/exceptions/DatabaseException.java framework/src/play/exceptions/MailException.java [#1840, #1848] Add warning / exception if version number is not provided in Dependencies [#1840, #1848] Update documentation for deps related to "Latest (Status) Matcher" and "Sub Revision Matcher" [#1854] Add colon in host + port for test baseUrl [#1566] Update to hibernate 4.2.15 [#1566] Partial Fix TransientObjectException when orphanRemoval = true and removing and adding items [#1503] Partial fix Nested OneToMany relationships with orphanRemoval fails to commit [#1847] Partial fix Orphan removal not cascaded for @OnetoOne relationships [#1823] Fix play.exceptions.CompilationException [#1823] Add a controller / package "application" to test the compilation error [#1823] Some fix on the method getJava removed java7 construct introduced in 6011111 [#1566] Update to c3p0-0.9.2.1 [#1566] Add missing hibernate-c3p0-4.2.15 library *[jobboard] Fix positional parameter warning [#1855] Fix AIOOB exception in WS.getQueryString [#1855] Add test for WS.getQueryString Javascript files must be at the end of the HTML See [Move Scripts to the Bottom](http://developer.yahoo.com/performance/rules.html#js_bottom) * Add build status in README.textile * Fix some javadoc error in comments * Fix indexOutOfBounds exception in playHander::parseRequest [#1857]Automatically convert existing sessions the first time people connect from an older 1.2 version of Play to the new v1.3, from then onwards the new cookie format will be used. [#1858] chore(netty): Update to netty 3.9.3.Final [#1832] perf(docviewer): add 'NoTransaction' annotation for controller PlayDocumentation and ProjectDocumentation [playframework#1319] Refactored the building of mock mails for better readability and maintainability [playframework#1319] Some small refactorings of Mail.send [playframework#1319] Extracted play.libs.mail.MailSystem concept from play.libs.Mail [playframework#1319] Use polymorphism of abstract MailSystem; determine concrete MailSystem implementation through factory method [playframework#1319] Extracted MailSystemFactory from play.libs.Mail [playframework#1319] Refactored play.libs.mail.DefaultMailSystemFactory [playframework#1319] Transformed the MailSystemFactory from anonymous instantiation to a class attribute [playframework#1319] Reduced the visibility of mail lib classes to encapsulate implementations in the play.libs.mail package [playframework#1319] "Improved the testability of mail sending" through implementation of substitution mechanisms for MailSystems [playframework#1319] Replaced the static *class* Mail.Mock through static *object* Mail.Mock After recompiling applications built upon previous versions, there are no problems. From a *plain* source code perspective, the caller syntax has not changed at all. [playframework#1319] Made as many methods in Mail.LegacyMockMailSystem non-static as possible WARNING: Test suites just-test-cases, i-am-a-developer and yabe failed sometimes. Results were NOT RELIABLY REPRODUCIBLE. [playframework#1319] Extracted inner class play.libs.Mail.LegacyMockMailSystem to play.libs.mail.test.LegacyMockMailSystem [playframework#1319] Moved play.libs.ImmediateFuture to play.util package ImmediateFuture is not specific to Play libraries. It is more like a generic utility that can be used in all concurrent environments. Conflicts: framework/src/play/libs/Mail.java [#1841] fix(invoker): Call invoker execute if no withinFilter function found * docs(build javadoc): Update links in the ant javadoc command [playframework#1049] fix(FileService): Support for HTTP ByteServing [#1859] fix(dependencies)Update link to playframework website, now used https://www.playframework.com [#1859] doc(playframework URL)Update link to playframework website, now used https://www.playframework.com [#1862] Try to get name of module from dependencies.yml (same as version) * fix(multiDB): add missing method edit(String dbName, ParamNode rootParamNode, String name) in GenericModel.java * fix(GenericModel): avoid exception if id is null * [#1868] fix(binder): not add element if no directBinding found * [#1868] test(binder): add test for binding entities * [#1868] feature(scope): add method removeStartWith in Params * [#1868] test(Scope): Add test for Scope * test(HttpResponse): fix dependencies to java.nio Update javadoc.py [#57987] Fix broken command by passing the full path for the command options * chore(lib): update async-http-client to v1.8.13 * chore(lib): update netty to v3.9.4.Final * fix(IO): don't close is as it can be used later * refactor(WS): remove unused import [#1872] fix(session): restore session, flash before new request even for serveStatic call [#1871] Refactor getJavaVersion * chore(lib): update to groovy V 2.3.6 * fix(Exception): remove useless cast to Exception (avoit incorrect cast exception) Methods should be protected so that they can be used/overidden from outside default package * Add specific method to allow to override the compiler options Remove ineffectice code for replacing class names. Our applications work well without it. artifacts named '*.jar' should not be treated as modules. this patch ensure local '.jar' artifacts are copied to 'lib/' instead of extracted to 'modules/'. named isInsideTransaction() should be used in named closeTx() Prevent connection leaks: do not create new EntityManager if transaction is not active. These newly-created EMs are not bound to thread and thus never closed. This is also how play 1.2.x used to work: no transaction - cannot read from DB. use JPA.DEFAULT constant, as a few lines above simplify code: use ThreadLocal's initialValue() to greatly reduce number of null checks use more efficient iterations and remove unused some code Allow developers to enable c3p0 logging for eg connection leak debugging via Log4J configuration. FallbackMLog logs to system error, which is not convenient. throw JPAExceptions in case of JPA errors instead of RuntimeExceptions - suggestion by xael-fry catch in isInsideTransaction() is not needed anymore as well, as JPAException is never thrown from the try block Restore method isInitialized to detect if JPA is initialized [#1880] Fix file handle leak in VirtualFile.content and VirtualFile.contentAsString [#1880] Close resources in finally block to avoid file handle leaks in case of exceptions [#1880] Use commons-io API to fix wrong usage of InputStream.read() [#1880] Use commons-io API to avoid re-inventing the wheel [#1880] Use commons-io API to avoid re-inventing the wheel - fixed compilation error [#1880] Use commons-io API to avoid re-inventing the wheel - fixed compilation error with Java 6 [#1881] Cache annotated method lists already in a sorted state. This prevents concurrent resorting of cached lists in multiple request threads, which sometimes results in ConcurrentModificationException, especially under Java 8. [#1883] Upgrade to Joda Time 2.5 fixed tests fix against XXE flaw [#1884] Skip static fields when building properties list [PR791] security: make FLASH cookie respect the HttpOnly config parameter security: make ERRORS cookie respect the HttpOnly config parameter fix typo in XML parser feature uri * fix(TemplateNotFoundException): test template to avoid NullPointerException Revert "[#1876] artifacts named '*.jar' should not be treated as modules." * Restore scala compatibility check ** but desactivate it by default ** use config param 'groovy.template.check.scala.comptatibility' to activate it [#1871] Updated the regular expression to not require "java" prefix and include letters and a dash to support Heroku Java 8 version string 'openjdk version "1.8.0_20-slim"'. Also prints out the version string if the specific version cannot be determined to enable debugging. simple upstart script [#1889] Fixed call to AsynchHttpClient builder.setBody() to pass in a byte array rather than an InputStream as an InputStream sets the transfer encoding to chunked. Updated AsynchHttpClient to v1.8.14 formTag: specifying the name parameter causes double name attributes [#1894] Updated Javassist to v3.19.0 RC1 that resolves an exception when enhancing a class with a Java 1.8 lambda expression [#1894] Removed Javassist v3.18.2-GA [#1894] Updated ASM from v5.0.2 to v5.0.3 [#1897] Added method play.mvc.Mailer.attachInlineEmbed(DataSource dataSource, String name) [#1898] Replaced c3p0 v0.9.2.1 with 0.9.5 [#1894] chore(lib): update Javassist to v3.19.0-GA * feat(test): add travis status [#1899] fix(PlayHandler): check if the channel because writing on it [#1897] Added example/test [#1897] Added example/test [#1897] Added final to data variable referenced in data source anonymous class to be compliant with Java 7 [#1899] fix(PlayHandler): change log level and message * [#1688] fix(session): mark session as changed when adding ID_KEY or AuthenticityToken [#1861] feat(validation): add new methods insert, remove, hasError Update utils.py Moving `java_path()` out of application into utils so `getJavaVersion()` can use it too Update application.py Move java_path to utils Update base.py Another instance of `java_path` changed Update deps.py Another instance of `java_path` changed Update evolutions.py Another instance of `java_path` changed * [#1907] chore(patch): add missing hibernate patch file hibernate-4.2.15-patch-play.patch Update JPAPlugin.java Remove useless onConfigurationRead function. It didn't do anything meaningful, nor was it used anywhere * [#1904] doc(configuration): update doc java.source ** 1.5 no longer supported ** 1.8 experimental (cf hibernate) * [#1904] feat(compiler): default compiler version of source = 1.6 * [#1903] fix(phoneValidation): fix validation to allow one number in the optional sub-zone * [#1903] test(phoneValidation): Add some test cases [#1878] Fixing evolution detection of mysql for all mysql dialects to get rid of error 'constraint play_evolutions_pkey' fix jar fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating FileArrayBinder to support empty file inputs in the request.
This is my first time contributing - please let me know what else I need to do.