Upgrade sbt-web plugins (to avoid repo.scala-sbt.org) #12340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Mergifyio backport 2.9.x |
✅ Backports have been created
|
mkurz
force-pushed
the
bye_com.github.sbt
branch
from
15169c4
to
36b5992
Compare
mkurz
force-pushed
the
bye_com.github.sbt
branch
from
fa58f6e
to
7467bd3
Compare
Closed
mkurz
force-pushed
the
bye_com.github.sbt
branch
from
7467bd3
to
96e2898
Compare
|
btw, while upgrading those plugins to latest sbt-web / latest webjars-locator I run into what I would think is a flaw in webjars-locator: (this is has nothing to do with Play per se, but with WebJars, which is used not only in Play apps, but anyone can use) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
They all uses latest sbt-web 1.5 / sbt-js-engine 1.3.x now, but most importantly are now hosted on maven central intead of deprecated https://repo.scala-sbt.org/ (see sbt/sbt#7202).
Only relevant for documentation and scripted tests (meaning if repo.scala-sbt.org goes down we can still successfully run our tests 😉)