Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scala 3.4.0 complains about x: _* syntax #736

Closed
ahjohannessen opened this issue Feb 22, 2024 · 0 comments · Fixed by #737
Closed

Scala 3.4.0 complains about x: _* syntax #736

ahjohannessen opened this issue Feb 22, 2024 · 0 comments · Fixed by #737

Comments

@ahjohannessen
Copy link
Contributor

ahjohannessen commented Feb 22, 2024

Using Scala 3.4.0 with twirl results in warnings like:

The syntax x: _* is no longer supported for vararg splices; use x* instead

The source of the issue comes from here and here using .toIndexedSeq:_* in codegen.

So, the methods compile and compileVirtual need to feed syntax variant options when invoking parseAndGenerateCode that in turn invokes generateFinalTemplate->generateCode.

Probably many ways to solve this. One is to change compile and compileVirtual to include scala version. I have no idea what maven-twirl and cradle-twirl do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant