compiler: account for Scala 2 and 3 differences in generated varargs code

[ahjohannessen]

This adds a bit of redudant overloads. The most important aspect for me now is that mima and tests pass plus a minor release can be shipped. At a later time, one can remove overloads and duplication, do a cleanup with a breaking change and bump major version or similar.

[ihostage]

@ahjohannessen @mkurz I checked this for Gradle and as I expected all is fine. The changes in twirl-compiler works fine for all supported build systems.

[ahjohannessen]

@ihostage That is great to hear :)

[mkurz]

Thanks!

I pushed a commit which adds an overloaded function so we stay compatible with previous releases. I know the plugin project is not checked by MiMa because we ususally don't guarantee compatibility for sbt plugins, but this is a cheap thing to do and avoids breaking apps in case someone relies on the method.
I just used a dummy scala version that makes sure Scala 2 code gets generated by default, just like before.

I will cut a new release after that.

[mkurz]

@Mergifyio backport 1.6.x

[mergify]

backport 1.6.x

✅ Backports have been created

• #738 [1.6.x] compiler: account for Scala 2 and 3 differences in generated varargs code (backport #737) by @ahjohannessen has been created for branch 1.6.x but encountered conflicts

[ahjohannessen]

@mkurz Super :) Next thing could perhaps be to introduce something like:

trait TwirlCompiler {
   def compile(…)
   // perhaps not necessary
   def compileVirtual(…)
}

and do some cleanup with compile options.

[mkurz]

@ahjohannessen Pull requests always welcome 😉