Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change groupId to org.playframework.twirl #676

Merged
merged 2 commits into from
Oct 6, 2023

Conversation

ihostage
Copy link
Member

@ihostage ihostage commented Sep 12, 2023

Before add Gradle Plugin we should finalize a groupId that also be used in Gradle Plugin Portal.

@ihostage
Copy link
Member Author

@mkurz @gmethvin WDYT?

@gmethvin
Copy link
Member

Any reason not to just use org.playframework for everything?

@ihostage
Copy link
Member Author

ihostage commented Sep 13, 2023

I think we shouldn't use top-level group org.playframework for independent project like Anorm and Twirl.
Anorm, for example, already use group org.playframework.anorm (source link, repo link) and I encourage that and think we should use the same approach for Twirl. Group org.playframework will be use for Play itself.

@mkurz
Copy link
Member

mkurz commented Sep 13, 2023

Actually I was thinking to keep com.typesafe for the 1.6 release (for which we published RC's already) and switch to org.playframework.[twirl] afterwards.

@ihostage
Copy link
Member Author

Yes, @mkurz, I also thought about this case. And that's all right for my. Just I thought if we haven't published final release 1.6 yet we can do rename by one step instead of two and save our time 😄

@ihostage ihostage mentioned this pull request Sep 21, 2023
@ihostage ihostage force-pushed the change-group-id branch 4 times, most recently from 34309e0 to 2b1b8c3 Compare September 26, 2023 14:11
@mkurz
Copy link
Member

mkurz commented Oct 5, 2023

I think we shouldn't use top-level group org.playframework for independent project like Anorm and Twirl.

The question here is what is an independent project? play-json also is an independent project, it does not depend on any of the Play (core) projects. play-ws also, it just depends on play-json. cachecontrol the same, no dependencies.
So following this rule we would need "org.playframework.play-json" %% "play-json", "org.playframework.cachecontrol" %% "cachecontrol" etc.

Anorm, for example, already use group org.playframework.anorm

I know, anorm always was a bit special... Also they were the only one for a long time to publish in the org.playframework groupId` already...

Group org.playframework will be use for Play itself.

Again the question what is Play itself? I already published play-ws 3 m1 (https://repo1.maven.org/maven2/org/playframework/play-ws_3/) under the "normal" groupId.

I understand for twirl it would make some sense, but I think it's more because of the name "twirl"... People use "play-json" without play also, same with "play-ws", people use it wilthout a Play application....

@ihostage
Copy link
Member Author

ihostage commented Oct 6, 2023

Yes, Matthias, I understand what you mean. Personally, I feel inwardly "independent" by next property:

  • Don't have a play suffix in the name
  • Is multi-module project, otherwise we don't need special groupId for one artifact.

And in fact except Anorm and Twirl I don't have other examples until 🤷‍♂️

@mkurz
Copy link
Member

mkurz commented Oct 6, 2023

OK, we can do that. So if artifacts start with play- (because they are play project related) we keep in top-level. If not starting with play- AND multi-module than in sub-group (like anorm, twirl, actually also netty-reactive-streams, see playframework/netty-reactive-streams#199). If not starting with play- AND NOT multi-module than also top-level (like cachecontrol. Actually would could rename it to play-cachecontrol but that does not make sense because it is totally independent of everything and a standalone project, it only depends on slf4j, also others use that library AFAIK, independent of Play).
In the end it's "just" naming, not a feature or bug fix...

@ihostage
Copy link
Member Author

ihostage commented Oct 6, 2023

It's ok to me. I agree 🤝

@mkurz mkurz merged commit e214554 into playframework:main Oct 6, 2023
14 checks passed
@ihostage ihostage deleted the change-group-id branch October 6, 2023 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants