-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change groupId to org.playframework.twirl
#676
Conversation
790c09a
to
81c1bce
Compare
81c1bce
to
1157953
Compare
Any reason not to just use |
I think we shouldn't use top-level group |
Actually I was thinking to keep |
Yes, @mkurz, I also thought about this case. And that's all right for my. Just I thought if we haven't published final release 1.6 yet we can do rename by one step instead of two and save our time 😄 |
34309e0
to
2b1b8c3
Compare
2b1b8c3
to
3b93eb1
Compare
The question here is what is an independent project? play-json also is an independent project, it does not depend on any of the Play (core) projects. play-ws also, it just depends on play-json. cachecontrol the same, no dependencies.
I know, anorm always was a bit special... Also they were the only one for a long time to publish in the
Again the question what is Play itself? I already published play-ws 3 m1 (https://repo1.maven.org/maven2/org/playframework/play-ws_3/) under the "normal" groupId. I understand for twirl it would make some sense, but I think it's more because of the name "twirl"... People use "play-json" without play also, same with "play-ws", people use it wilthout a Play application.... |
Yes, Matthias, I understand what you mean. Personally, I feel inwardly "independent" by next property:
And in fact except Anorm and Twirl I don't have other examples until 🤷♂️ |
OK, we can do that. So if artifacts start with |
It's ok to me. I agree 🤝 |
Before add Gradle Plugin we should finalize a groupId that also be used in Gradle Plugin Portal.