Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix format imports for Gradle/Maven #719

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

ihostage
Copy link
Member

@ihostage ihostage commented Dec 7, 2023

@ihostage ihostage requested a review from mkurz December 7, 2023 10:28
@mkurz
Copy link
Member

mkurz commented Dec 7, 2023

Is this just formatting?

@mkurz
Copy link
Member

mkurz commented Dec 7, 2023

ah I see more than that

@ihostage
Copy link
Member Author

ihostage commented Dec 7, 2023

Is this just formatting?

Yes. I added formatting imports before compilation for Gradle/Maven plugins because I missed this logic while implemented these plugins. 🤦‍♂️
Plus I modified tests to check formatting and added one public method formatImports into play.japi.twirl.compiler.TwirlCompiler.

Copy link
Member

@mkurz mkurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only care about compiler/src/main/java/play/japi/twirl/compiler/TwirlCompiler.java which is LGTM 😉

@mkurz mkurz merged commit 4fdf417 into playframework:main Dec 7, 2023
15 checks passed
@mkurz
Copy link
Member

mkurz commented Dec 7, 2023

Will release as 2.0.3, let me check if we need to upgrade other dependencies...

@ihostage ihostage deleted the format-imports branch December 7, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants