Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin Scala LTS version for Steward #758

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Conversation

ihostage
Copy link
Member

No description provided.

@ihostage ihostage requested a review from mkurz April 25, 2024 12:00
@ihostage
Copy link
Member Author

@mkurz Do you know, why Steward haven't created update to 3.4 yet? 🤔

@mkurz
Copy link
Member

mkurz commented Apr 25, 2024

@mkurz Do you know, why Steward haven't created update to 3.4 yet? 🤔

hmm.. maybe because in #751 it upgraded to from 3.3.1 to 3.3.3 and maybe on next visit it would then upgrade to 3.4.
I think scala-steward first tries to upgrade to latest patch version, then it upgrades to latest minor version and so on. But not 100% sure.

See answer below.

@ihostage
Copy link
Member Author

I have the same assumption. Anyway this pin will be useful for us 😄

@mkurz mkurz merged commit 4186b4d into playframework:main Apr 25, 2024
14 checks passed
@ihostage ihostage deleted the pin-scala-3-3 branch April 25, 2024 12:10
@ihostage
Copy link
Member Author

@Mergifyio backport 1.6.x

Copy link
Contributor

mergify bot commented Apr 25, 2024

backport 1.6.x

✅ Backports have been created

mkurz added a commit that referenced this pull request Apr 25, 2024
[1.6.x] Pin Scala LTS version for Steward (backport #758) by @ihostage
@mkurz
Copy link
Member

mkurz commented Apr 25, 2024

@mkurz Do you know, why Steward haven't created update to 3.4 yet? 🤔

Here is the solution: https://github.com/scala-steward-org/scala-steward/blob/ddfdff8d6a9f587f4bc452a6cf10cb76734fbaae/modules/core/src/main/resources/default.scala-steward.conf#L33-L36

updates.ignore = [
   ...

  // No upgrades to non LTS versions
  { groupId = "org.scala-lang", artifactId = "scala3-compiler",     version = { prefix = "3.4." } },
  { groupId = "org.scala-lang", artifactId = "scala3-library",      version = { prefix = "3.4." } },
  { groupId = "org.scala-lang", artifactId = "scala3-library_sjs1", version = { prefix = "3.4." } },

  ...

@ihostage
Copy link
Member Author

Cooool! 😄 Don't need to pin LTS in all repos 🥳

@mkurz
Copy link
Member

mkurz commented Apr 25, 2024

We can keep this two pull requests because one day the main branch will become 2.0.x and there we will not want scala to be upgraded anymore. But yes we do not need to add the pins everywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants