Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: JSON parsing in browser mode #125

Merged
merged 1 commit into from
Dec 13, 2024
Merged

fix: JSON parsing in browser mode #125

merged 1 commit into from
Dec 13, 2024

Conversation

momintlh
Copy link
Collaborator

@momintlh momintlh commented Dec 13, 2024 •
edited
Loading

  • JSON parsing with simpleJSON instead of built-in handler

@momintlh momintlh requested a review from SaadBazaz December 13, 2024 11:41
SaadBazaz
SaadBazaz approved these changes Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@SaadBazaz SaadBazaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
This should be caught by our tests. 🤔

@momintlh momintlh merged commit 7f4c90a into main Dec 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaadBazaz SaadBazaz SaadBazaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@momintlh @SaadBazaz