Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: RPC events sync. #67

Merged
merged 7 commits into from
May 11, 2024
Merged

fix: RPC events sync. #67

merged 7 commits into from
May 11, 2024

Conversation

momintlh
Copy link
Collaborator

@momintlh momintlh commented May 9, 2024 •
edited
Loading

Temporary fix, RPC part needs to be refactored, might be better to handle within JS. #40

@momintlh
fix: RPC events sync.
8b28295 
- RPC events name sync between players.
- Made Players dictionary private #66
@momintlh momintlh requested a review from SaadBazaz May 9, 2024 18:42
SaadBazaz
SaadBazaz requested changes May 9, 2024
View reviewed changes
Copy link
Collaborator

@SaadBazaz SaadBazaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either my eyes are deceiving me, or I can't see the private Players change.

Assets/PlayroomKit/PlayroomKit.cs Show resolved Hide resolved
@momintlh momintlh requested a review from SaadBazaz May 9, 2024 18:50
SaadBazaz
SaadBazaz requested changes May 9, 2024
View reviewed changes
Copy link
Collaborator

@SaadBazaz SaadBazaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Add description comments
  • Write dry runs on all cases in mind (no need to actually build and run)

SaadBazaz
SaadBazaz approved these changes May 10, 2024
View reviewed changes
Assets/PlayroomKit/PlayroomKit.cs Outdated Show resolved Hide resolved
@SaadBazaz
Copy link
Collaborator

I have a hunch this methodology might cause Race conditions upon high load. Needs testing on high performance calls between multiple players, with multiple RPCs.

Instead of saving a state, maybe send some metadata alongside each RPC call? That way, it's guaranteed to reach along with the RPC call.

SaadBazaz
SaadBazaz requested changes May 10, 2024
View reviewed changes
Copy link
Collaborator

@SaadBazaz SaadBazaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What scenarios has this been tested on?

Assets/PlayroomKit/PlayroomKit.cs Show resolved Hide resolved
Assets/PlayroomKit/PlayroomKit.cs Show resolved Hide resolved
@SaadBazaz SaadBazaz mentioned this pull request May 11, 2024
Closed
@SaadBazaz
Copy link
Collaborator

SaadBazaz commented May 11, 2024 •
edited
Loading

Merging in favor of a working solution instead of over engineering. Noted down problems in Refactor Umbrella issue.

@SaadBazaz SaadBazaz merged commit b105cce into main May 11, 2024
2 checks passed
This was referenced May 11, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaadBazaz SaadBazaz SaadBazaz requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@momintlh @SaadBazaz