Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change dynCall to makeDynCall #93

Merged
merged 10 commits into from
Oct 7, 2024
Merged

Change dynCall to makeDynCall #93

merged 10 commits into from
Oct 7, 2024

Conversation

aarijimam
Copy link
Contributor

Playroomkit

This pull request is to change dynCall to makeDynCall.

Type of Change

  • Changed the now deprected dynCall to makeDynCall.

Test Devices:

  • Unity: 2022.3.23f1
  • Chrome: 129.0.6668.90
  • Operating System: macOS 15.1

Changes

  • Assets/PlayroomKit/src/index.js: Changed dynCall to makeDynCall.

Checklist:

  • Ran tests on 2d-platformer and discord-activity, working as intended.
  • Checked errors to make sure none pertain to the changes.
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code

@SaadBazaz SaadBazaz linked an issue Oct 7, 2024 that may be closed by this pull request
Change dynCall to makeDynCall #94
Closed
SaadBazaz
SaadBazaz approved these changes Oct 7, 2024
View reviewed changes
Copy link
Collaborator

@SaadBazaz SaadBazaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Minor nit, fix please.

Assets/chromedriver Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please place this file somewhere outside of the project, and set the path accordingly. Otherwise this will change every time there is a person with a different OS.

I'd recommend nuking it entirely from this project and/or adding it in .gitignore
i.e.

Assets/chromedriver.*

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added driver to gitignore

SaadBazaz
SaadBazaz approved these changes Oct 7, 2024
View reviewed changes
Copy link
Collaborator

@SaadBazaz SaadBazaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for the chromedriver cleanup. Will add in CONTRIBUTING (#101 ) later.

@SaadBazaz SaadBazaz merged commit 344160f into playroomkit:main Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaadBazaz SaadBazaz SaadBazaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
PlayroomKit SDK for Unity
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change dynCall to makeDynCall
2 participants
@aarijimam @SaadBazaz